Code review comment for lp:~jameinel/loggerhead/pygment-annotate-fail

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/11/2011 2:00 PM, Brad Crittenden wrote:
> Review: Approve code
> Hi John,
>
> s/pigments/pygments/
>
> Your comment at 37 is a bit misleading as it only happens if pygments is installed. Perhaps reword that statement to remove references to "now" since it isn't an on-going issue but only if pygments is installed.
>
> I like Benji's suggestion to clean up the results rather than match something that is overly broad.

Thanks. I went with just stripping all <span class="pyg-."> entries and
all </span> entries. Which gives the same basic results.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1Vt+cACgkQJdeBCYSNAANxEwCgu2nuYuQYgzTANHdQCN6MnbfK
r40AoMuWFmgQNBY/zVYG3WKlqKwIKUES
=5992
-----END PGP SIGNATURE-----

« Back to merge proposal