The "with.*<.*htmlspecialchars" regex feels a bit too liberal. How
about something like this?
# remove any pygments-inserted tags
body = re.sub('<[^>]+>', '', res.body)
self.assertContains(body, "with<htmlspecialchars")
Also, I suspect judicious use of a clean Python and buildout would help
with this scenario, providing reproducible builds isolated from the
environment. If you're interested I'd be glad to help craft a buildout
for the project.
Regardless, the branch is certainly approvable as is, so I've done so.
Note that this is a mentored review so Brad will be reviewing my review
and giving the final approval.
The "with.* <.*htmlspeci alchars" regex feels a bit too liberal. How
about something like this?
# remove any pygments-inserted tags assertContains( body, "with< htmlspecialchar s")
body = re.sub('<[^>]+>', '', res.body)
self.
Also, I suspect judicious use of a clean Python and buildout would help
with this scenario, providing reproducible builds isolated from the
environment. If you're interested I'd be glad to help craft a buildout
for the project.
Regardless, the branch is certainly approvable as is, so I've done so.
Note that this is a mentored review so Brad will be reviewing my review
and giving the final approval.