Code review comment for lp:~jameinel/launchpadlib/win32

Revision history for this message
Gary Poster (gary) wrote :

> This looks good and works for me. However, if we're going to do this I wonder
> if it might make sense to just move _bootstrap/bootstrap.py into the top-level
> directory. That also seems to work, and it's less code. Approved* pending
> Gary's (probably negative) opinion of that idea.

My only concern is actually a legal one. I was keeping (trying to keep) the ZPL bits (including the license itself) down in that directory for legal cleanliness.

Another, similar approach would be to remove the top-level bootstrap.py, move _bootstrap dir -> bootstrap, and have the instructions be to run bootstrap/bootstrap.py. As another alternative, we can go for cutesy, like boot/strap.py.

I don't care if we do what you propose though (and that's what I do when the whole package is ZPL), especially if kfogel or someone similarly comfortable with opinions about license stuff like this approves.

« Back to merge proposal