Code review comment for lp:~jameinel/launchpad/twisted-close-on-failure

Revision history for this message
Brad Crittenden (bac) wrote :

I concur with Benji's review. I had the same questions regarding the asserts and think Benji's suggestion for rephrasing the comments makes the code more clear.

The code does look to be much more robust than what we currently have.

I'll mark this branch mentored (approved) and let you and Benji sort out the questions he raised.

review: Approve (code)

« Back to merge proposal