After a conversation in IRC, I realize I have misunderstood the situation. Given that, I think is fine.
6:22 PM jam
jcsacket: ... I have run the specific code quite thoroughly, and there are some tests that already cover it.
6:22 PM
It is a little bit hard to inject specific failures into that exact point. If you feel it is critical, we can try to figure something out
6:22 PM
but I did do a lot of manual testing.
6:22 PM jcsackett
jam: ah, in your MP you said there were no tests; i took that to mean no testing. :-)
After a conversation in IRC, I realize I have misunderstood the situation. Given that, I think is fine.
6:22 PM jam
jcsacket: ... I have run the specific code quite thoroughly, and there are some tests that already cover it.
6:22 PM
It is a little bit hard to inject specific failures into that exact point. If you feel it is critical, we can try to figure something out
6:22 PM
but I did do a lot of manual testing.
6:22 PM jcsackett
jam: ah, in your MP you said there were no tests; i took that to mean no testing. :-)
6:22 PM jam
no new tests covering what changed
6:23 PM jcsackett
dig.