Code review comment for lp:~jameinel/juju-core/only-943

Revision history for this message
John A Meinel (jameinel) wrote :

Reviewers: mp+151005_code.launchpad.net,

Message:
Please take a look.

Description:
revert only r943

William merged a change which reverted trunk back to 942
because rev 943 broke the test suite.

This just re-introduces all of the merges 944-947, so that
Gustavo and Ian don't have to re-propose and get approval
for their changes again.

I've run the test suite to make sure it passes as long as
just 943 has been removed.

In the future, you can just cherrypick-out specific revisions
with (eg):
  bzr merge . -r 943..942

And then run the test suite, and propose it. (Which is essentially
what this patch does, except it also reverts 948 which removed
all of those other revisions.)

https://code.launchpad.net/~jameinel/juju-core/only-943/+merge/151005

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7424046/

Affected files:
   A [revision details]
   M cmd/cmd.go
   M cmd/cmd_test.go
   M cmd/filevar_test.go
   M cmd/juju/addrelation_test.go
   M cmd/juju/addunit_test.go
   M cmd/juju/bootstrap_test.go
   M cmd/juju/cmd_test.go
   M cmd/juju/config_test.go
   M cmd/juju/constraints_test.go
   M cmd/juju/deploy_test.go
   M cmd/juju/destroymachine_test.go
   M cmd/juju/destroyrelation_test.go
   M cmd/juju/destroyservice_test.go
   M cmd/juju/destroyunit_test.go
   M cmd/juju/expose_test.go
   M cmd/juju/init_test.go
   M cmd/juju/resolved_test.go
   M cmd/juju/scp_test.go
   M cmd/juju/ssh_test.go
   M cmd/juju/status_test.go
   M cmd/juju/unexpose_test.go
   M cmd/juju/upgradejuju_test.go
   M cmd/jujud/agent_test.go
   M cmd/jujud/bootstrap_test.go
   M cmd/logging_test.go
   M cmd/output_test.go
   M cmd/supercommand_test.go
   M cmd/util_test.go
   M environs/agent/agent.go
   M juju/api.go
   M juju/conn.go
   M state/api/api_test.go
   M state/api/error.go
   M state/open.go
   M state/state_test.go
   M state/unit_test.go
   M store/server.go
   M store/server_test.go
   M store/store.go
   M store/store_test.go
   M testing/cmd.go
   M worker/uniter/jujuc/config-get_test.go
   M worker/uniter/jujuc/ports_test.go
   M worker/uniter/jujuc/relation-get_test.go
   M worker/uniter/jujuc/relation-ids_test.go
   M worker/uniter/jujuc/relation-list_test.go
   M worker/uniter/jujuc/relation-set_test.go
   M worker/uniter/jujuc/server.go
   M worker/uniter/jujuc/unit-get_test.go
   M worker/uniter/jujuc/util_test.go

« Back to merge proposal