https://codereview.appspot.com/87570043/diff/1/agent/mongo/mongo.go#newcode255
agent/mongo/mongo.go:255: logger.Debugf("found mongod at: %s",
mongopath)
On 2014/04/16 10:47:20, nate.finch wrote:
> maybe put this after the err check, just on the off chance we *don't*
find mongo
> there? or change the message to "checking version of mongo at <path>?
I originally had it as one message, but then I wanted to make sure to
log something on error. But I realize we'll have that data as long as we
put the path in the output, so I'll fix it to just at the end. (Nicer
not to have lots of lines anyway.
Please take a look.
https:/ /codereview. appspot. com/87570043/ diff/1/ agent/mongo/ mongo.go mongo.go (right):
File agent/mongo/
https:/ /codereview. appspot. com/87570043/ diff/1/ agent/mongo/ mongo.go# newcode255 mongo.go: 255: logger. Debugf( "found mongod at: %s",
agent/mongo/
mongopath)
On 2014/04/16 10:47:20, nate.finch wrote:
> maybe put this after the err check, just on the off chance we *don't*
find mongo
> there? or change the message to "checking version of mongo at <path>?
I originally had it as one message, but then I wanted to make sure to
log something on error. But I realize we'll have that data as long as we
put the path in the output, so I'll fix it to just at the end. (Nicer
not to have lots of lines anyway.
https:/ /codereview. appspot. com/87570043/ diff/1/ agent/mongo/ mongo.go# newcode259 mongo.go: 259: logger. Infof(" failed to read the output from
agent/mongo/
%s --version", mongopath)
On 2014/04/16 10:47:20, nate.finch wrote:
> should we log the error? it could be "mongod not found"
logged
https:/ /codereview. appspot. com/87570043/