Yeah, I think this is a panic. Someone completely screwed up, do not
pass go, do not collect $200.
https://codereview.appspot.com/11137044/diff/1/cmd/jujud/upgradevalidation.go#newcode165
cmd/jujud/upgradevalidation.go:165: if err :=
setter.SetPassword(password); err != nil {
Hmm. The original idea IIRC was that we save the oldPassword (for
recovery purposes), write the new password to disk, and then really set
the new password. Not quite sure this mechanism and that one are
properly joined-up?
Looking very nice, thanks for this; I have a couple of questions.
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ machine. go machine. go (right):
File cmd/jujud/
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ machine. go#newcode145 machine. go:145: // TODO: Once we can reliably trust that we
cmd/jujud/
have API passwords
Give this a TODO(jam), it's nice to be able to know who to ask even when
blame info is lost through unrelated changes.
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ machine_ test.go machine_ test.go (right):
File cmd/jujud/
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ machine_ test.go# newcode73 machine_ test.go: 73: err = conf.Write()
cmd/jujud/
thanks, good catch
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ upgradevalidati on.go upgradevalidati on.go (right):
File cmd/jujud/
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ upgradevalidati on.go#newcode11 0 upgradevalidati on.go:110: }
cmd/jujud/
Can you use State.APIAddresses for this? Or something like that...
defined in state/open.go I think.
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ upgradevalidati on.go#newcode13 4 upgradevalidati on.go:134: // This is unexpected as all
cmd/jujud/
AgentState objects (Machine and Unit)
On 2013/07/15 13:31:43, mue wrote:
> Isn't this worth a panic()? How does the system continue with this
error?
Yeah, I think this is a panic. Someone completely screwed up, do not
pass go, do not collect $200.
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ upgradevalidati on.go#newcode16 5 upgradevalidati on.go:165: if err := SetPassword( password) ; err != nil {
cmd/jujud/
setter.
Hmm. The original idea IIRC was that we save the oldPassword (for
recovery purposes), write the new password to disk, and then really set
the new password. Not quite sure this mechanism and that one are
properly joined-up?
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ upgradevalidati on_test. go upgradevalidati on_test. go (right):
File cmd/jujud/
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ upgradevalidati on_test. go#newcode47 upgradevalidati on_test. go:47: func (s ionMachineSuite ) Create1_10Machine(c *gc.C) hine?
cmd/jujud/
*UpgradeValidat
(*state.Machine, *agent.Conf) {
On 2013/07/15 13:31:43, mue wrote:
> Needed a few seconds to interpret 1_10 right. ;) How about
Create1Dot10Mac
-1 myself, but happy to follow consensus
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ upgradevalidati on_test. go#newcode226 upgradevalidati on_test. go:226: func (s ionUnitSuite) TestEnsureAPIIn fo111(c *gc.C) {
cmd/jujud/
*UpgradeValidat
1_11 for consistency with the above?
https:/ /codereview. appspot. com/11137044/ diff/1/ cmd/jujud/ upgradevalidati on_test. go#newcode247 upgradevalidati on_test. go:247: func (s ionUnitSuite) TestEnsureAPIIn fo111Noop( c *gc.C) {
cmd/jujud/
*UpgradeValidat
ditto
https:/ /codereview. appspot. com/11137044/