Code review comment for lp:~jameinel/juju-core/1.18-authorized-keys-1312537

Reviewers: mp+217174_code.launchpad.net,

Message:
Please take a look.

Description:
rename authorised-keys to authorized-keys

This addresses bug #1312537. We were very inconsistent about whether
then name was "authorized-keys" or "authorised-keys". I can understand
the cultural spelling biasies. I originally intended to just alias the
command to 'authorized-keys' but then I realized the environments.yaml
setting is 'authorized-keys' so I felt it would be best to be consistent
with something we can't change at this point.

The patch was written against 1.18, so it should be trivial to land it
there, but I'm proposing it just against trunk to start with. We could
also do a more-trivial patch that just adds 'authorized-keys' as the
alias for 1.18, but it means that 'juju help authorized-keys' will tell
you the command is called 'authorised-keys' which I feel should change
in 1.19+.

https://code.launchpad.net/~jameinel/juju-core/1.18-authorized-keys-1312537/+merge/217174

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/93800043/

Affected files (+77, -45 lines):
   A [revision details]
   M cmd/juju/authorizedkeys.go
   M cmd/juju/authorizedkeys_add.go
   M cmd/juju/authorizedkeys_delete.go
   M cmd/juju/authorizedkeys_import.go
   M cmd/juju/authorizedkeys_list.go
   M cmd/juju/authorizedkeys_test.go
   M cmd/juju/help_topics.go
   M cmd/juju/main.go
   M cmd/juju/main_test.go
   M cmd/supercommand.go
   M cmd/supercommand_test.go
   M scripts/win-installer/setup.iss
   M version/version.go