Code review comment for lp:~jameinel/bzr/preview-pull-760152

On Wed, 2011-04-20 at 09:54 +0000, John A Meinel wrote:
> John A Meinel has proposed merging lp:~jameinel/bzr/preview-pull-760152 into lp:bzr/2.3.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> Bug #760152 in Bazaar: "bzr merge --pull --preview BRANCH does not always honor the --preview option"
> https://bugs.launchpad.net/bzr/+bug/760152
>
> For more details, see:
> https://code.launchpad.net/~jameinel/bzr/preview-pull-760152/+merge/58460
>
> This is a small tweak to the merge code.

   review approve

> I'm targeting 2.3, though we could easily backport this as far back as we want. (The initial change is on the 2.1 branch, but the NEWS update is obviously on 2.3)
Since this was only reported recently I wonder many people will actually
be affected by this and so how useful it would be to backport further
than 2.3. On the other hand, it also doesn't look like a very risky
change.

Cheers,

Jelmer