Code review comment for lp:~jameinel/bzr/bugfix399366

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Review: Approve
> AFAICS the penalty would be once (or twice) per heads() call, so nothing dramatic.
> Did you measure it ?
>
> Otherwise, it's trivial and required, so land it !

well, it is 1/heads call, and back when we were calling heads() 200k
times for NEWS, it isn't that trivial.

But the code has changed, and yeah, I don't think it is particularly
dramatic.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpczn8ACgkQJdeBCYSNAAMDgACgjrsImFm6S+oQXNWhs7MB167E
xdsAn217qlEcDR6Y+uU6IrmBfxw3mJVD
=HTIX
-----END PGP SIGNATURE-----

« Back to merge proposal