Vincent Ladeuil wrote:
> Review: Approve
> AFAICS the penalty would be once (or twice) per heads() call, so nothing dramatic.
> Did you measure it ?
>
> Otherwise, it's trivial and required, so land it !
well, it is 1/heads call, and back when we were calling heads() 200k
times for NEWS, it isn't that trivial.
But the code has changed, and yeah, I don't think it is particularly
dramatic.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Vincent Ladeuil wrote:
> Review: Approve
> AFAICS the penalty would be once (or twice) per heads() call, so nothing dramatic.
> Did you measure it ?
>
> Otherwise, it's trivial and required, so land it !
well, it is 1/heads call, and back when we were calling heads() 200k
times for NEWS, it isn't that trivial.
But the code has changed, and yeah, I don't think it is particularly
dramatic.
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org
czn8ACgkQJdeBCY SNAAMDgACgjrsIm Fm6S+oQXNWhs7MB 167E Y+uU6IrmBfxw3mJ VD
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkp
xdsAn217qlEcDR6
=HTIX
-----END PGP SIGNATURE-----