I've begun reviewing this, but threads make me sad and I'm not really familiar with this code (yet).
I've noticed some really minor issues, but I'll try to follow up with some actually useful comments (once I understand the global picture a bit better).
you have an import conflict in bzrlib/smart/medium.py
206 + # have a good way (yet) to poll the spawned clients and
... and what ? :)
246 + if e.args[0] not in (errno.EBADF, errno.EINTR):
The comment above this line should probably be updated.
I've begun reviewing this, but threads make me sad and I'm not really familiar with this code (yet).
I've noticed some really minor issues, but I'll try to follow up with some actually useful comments (once I understand the global picture a bit better).
you have an import conflict in bzrlib/ smart/medium. py
206 + # have a good way (yet) to poll the spawned clients and
... and what ? :)
246 + if e.args[0] not in (errno.EBADF, errno.EINTR):
The comment above this line should probably be updated.