Code review comment for lp:~jameinel/bzr/2.4-transform-cache-sha-740932

Revision history for this message
Andrew Bennetts (spiv) wrote :

The change to bzrlib/dirstate.py looks reasonable (it's certainly more readable!) but I'm not sure how it's related to the rest of this patch… hmm, I guess that bit has actually already landed from with your 2.4-observed-sha-updates-size patch anyway.

Anyway, the change and new tests look good to me!

review: Approve

« Back to merge proposal