Code review comment for lp:~jameinel/bzr/2.4-fdatasync-ENOTSUP-1075108

Revision history for this message
Vincent Ladeuil (vila) wrote :

> I like being cautious, but I also like not preventing someone from
> actually getting their work done until we manage to add one more error
> code into an exception clause.

My point was more about a valid fdatasync() error that would reveal a data loss and will be ignored with your patch.

« Back to merge proposal