Code review comment for lp:~jameinel/bzr/2.4-disable-selftest-fdatasync-837293

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/02/2011 11:16 AM, Vincent Ladeuil wrote:
> Review: Approve
> Do we still have tests that would revert the effect of your patch and explicitly test fdatasync ?
>
> If not, a follow-up addressing that would be nice (features.with_fdatasync or something), I see no point in *always* testing fdatasync, but I'm a bit concerned about *never* testing it.

You can run "bzr selftest --sync". We still have the test that is
asserting os.fdatasync is getting called if it exists.

Is there something else that you need?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5gpEMACgkQJdeBCYSNAAMdKQCgpGSstlSjZV3EyIhNJjWncwPM
PecAoJeThVdSA6jiJDVsT1IKXdz6y6AM
=BGdd
-----END PGP SIGNATURE-----