Code review comment for lp:~jameinel/bzr/2.3-avoid-xmlrpc-ssh-397739

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/24/2011 5:32 AM, Martin Pool wrote:
> That's great, thanks for fixing it!
>
> I would not put this into 2.3 until we were sure it was ok in trunk;
> there is a medium-high risk of interaction bugs.
>
> Martin

Looks like Andrew has already found one. Namely, stacking doesn't seem
to be triggering correctly on +branch/~user/project/branch listings.

We could change the local resolution to be absolute if it is fully
specified.

So if you supply 2 parts (or 3 parts with one being ubuntu/debian) then
we would use +branch, otherwise we just do the full expansion.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2K4c8ACgkQJdeBCYSNAAPD0wCeNa9xRqetVlGGrwQeWnzg79Uz
JIsAn0HdHD2HR2aGq8hSdbGT/F9jAx2u
=qSZ1
-----END PGP SIGNATURE-----