Code review comment for lp:~jameinel/bzr/2.1.0b4-win32-unsupported_encoding_commit_message

John A Meinel (jameinel) wrote :

Another small update to get the test suite passing on windows. From the commit message:

test_unsupported_encoding_commit_message no longer applies for Windows.

We now parse a Unicode string directly, so it isn't really possible to pass
a non-ascii string that will fail to decode.

I'm slowly building these up into a separate 'win32 test suite' branch, but I figured it would be a lot easier to review them one-at-a-time.

Then if anything ends up being controversial, it doesn't have to block the rest of them.

« Back to merge proposal