Bazaar

Merge lp:~jameinel/bzr/2.1.0b4-win32-test-imports into lp:bzr

  1. 2.1.0b4-win32-test-imports
  2. Merge into bzr.dev
Proposed by John A Meinel
Status: Merged
Approved by: Martin Pool
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~jameinel/bzr/2.1.0b4-win32-test-imports
Merge into: lp:bzr
Diff against target: 41 lines (+20/-0)
2 files modified
NEWS (+5/-0)
doc/developers/testing.txt (+15/-0)
To merge this branch: bzr merge lp:~jameinel/bzr/2.1.0b4-win32-test-imports
Reviewer Review Type Date Requested Status
Martin Pool Approve
Review via email: mp+15877@code.launchpad.net
To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

This is the NEWS entry and testing paragraph that Martin mentioned. I like it enough, but I figured I'd check before landing.

Revision history for this message
Martin Pool (mbp) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

  vote approve
  status approved

Perfect
- --
Martin <http://launchpad.net/~mbp/>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAksgRBgACgkQPGPKP6Cz6IsfRgCglZ7JDaseYbGE30ofL3hRKf6/
z9QAniLTXzMmSocTNjlqw0pyjSVm1MHc
=X5nm
-----END PGP SIGNATURE-----

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NEWS'
--- NEWS 2009-12-09 05:47:32 +0000
+++ NEWS 2009-12-09 15:50:30 +0000
@@ -116,6 +116,11 @@
116Internals116Internals
117*********117*********
118118
119* New test Feature: ``ModuleAvailableFeature``. It is designed to make it
120 easier to handle what tests you want to run based on what modules can be
121 imported. (Rather than lots of custom-implemented features that were
122 basically copy-and-pasted.) (John Arbash Meinel)
123
119* Several code paths that were calling ``Transport.get().read()`` have124* Several code paths that were calling ``Transport.get().read()`` have
120 been changed to the equalivent ``Transport.get_bytes()``. The main125 been changed to the equalivent ``Transport.get_bytes()``. The main
121 difference is that the latter will explicitly call ``file.close()``,126 difference is that the latter will explicitly call ``file.close()``,
122127
=== modified file 'doc/developers/testing.txt'
--- doc/developers/testing.txt 2009-12-02 20:34:07 +0000
+++ doc/developers/testing.txt 2009-12-09 15:50:30 +0000
@@ -353,6 +353,21 @@
353 KnownFailure should be used with care as we don't want a353 KnownFailure should be used with care as we don't want a
354 proliferation of quietly broken tests.354 proliferation of quietly broken tests.
355355
356ModuleAvailableFeature
357 A helper for handling running tests based on whether a python
358 module is available. This can handle 3rd-party dependencies (is
359 ``paramiko`` available?) as well as stdlib (``termios``) or
360 extension modules (``bzrlib._groupcompress_pyx``). You create a
361 new feature instance with::
362
363 MyModuleFeature = ModuleAvailableFeature('bzrlib.something')
364
365 ...
366 def test_something(self):
367 self.requireFeature(MyModuleFeature)
368 something = MyModuleFeature.module
369
370
356We plan to support three modes for running the test suite to control the371We plan to support three modes for running the test suite to control the
357interpretation of these results. Strict mode is for use in situations372interpretation of these results. Strict mode is for use in situations
358like merges to the mainline and releases where we want to make sure that373like merges to the mainline and releases where we want to make sure that