Merge lp:~jameinel/bzr/2.1-st-from-iterable into lp:bzr
Proposed by
John A Meinel
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~jameinel/bzr/2.1-st-from-iterable |
Merge into: | lp:bzr |
Diff against target: |
86 lines 2 files modified
bzrlib/_static_tuple_c.c (+14/-8) bzrlib/tests/test__static_tuple.py (+15/-0) |
To merge this branch: | bzr merge lp:~jameinel/bzr/2.1-st-from-iterable |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vincent Ladeuil | Approve | ||
Review via email: mp+14027@code.launchpad.net |
To post a comment you must log in.
This is a small cleanup of Matt Nordhoff's update for 'from_sequence'. Basically, it changes the internals such that if an object isn't a simple sequence, we cast it to a tuple and then use that instead.
It means you can do "StaticTuple. from_sequence( generator) " which is what they had been doing in loggerhead. (using tuple(generator).)
I don't think we *need* this, but if it helps someone, I'm ok with it.