Code review comment for lp:~jameinel/bzr/2.1-launchpad-package-freshness-609187

On 16/08/11 16:30, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 8/16/2011 4:27 PM, Jelmer Vernooij wrote:
>> Review: Approve I have only briefly glanced over this. I've
>> specifically checked the overriding of attributes and
>> iter_reverse_revision_history. That all looks good to me.
>>
>> It would be useful to test this with 2.4, in case this uses anything
>> that relies on 2.5 or 2.6. I can't find anything when looking
>> manually.
> I'm not sure what you mean by 2.4. But we already have this landed into
> the 2.4 series, using the newer apis.
Sorry, that was ambiguous. I meant compatible with python 2.4,
considering we still try to support it for bzr 2.1. I'm also not sure
what PQM uses to land things on lp:bzr/2.1 these days (if it's python2.6
we need to be careful).

Cheers,

Jelmer