Code review comment for lp:~jameinel/bzr/2.1-launchpad-package-freshness-609187

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/16/2011 4:27 PM, Jelmer Vernooij wrote:
> Review: Approve I have only briefly glanced over this. I've
> specifically checked the overriding of attributes and
> iter_reverse_revision_history. That all looks good to me.
>
> It would be useful to test this with 2.4, in case this uses anything
> that relies on 2.5 or 2.6. I can't find anything when looking
> manually.

I'm not sure what you mean by 2.4. But we already have this landed into
the 2.4 series, using the newer apis.

When I merge this up, I plan on using whatever apis are available at
each stage.

And I did make sure that:

a) The test suite passes
b) Activating the "DONT_*" tests that actually connect to launchpad and
make a query and parse the result also still pass.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5KfxoACgkQJdeBCYSNAAMr3QCgt8cHcfB33bSHg+tPnNzFKY5I
/p8AnRZpY9lxZZyQ9uNUg/mNCcgSPzqj
=RlmU
-----END PGP SIGNATURE-----