Code review comment for lp:~jameinel/bzr/2.0.3-433779-sanitize-commit-m

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Review: Approve
> Thanks for that.
>
> I fail to see what can possibly go wrong, why is why I agree we should land it in 2.1 first ;)
>
> For the sake of example, you could have used the shell-like tests here, up to the run_bzr part.
>
>

Except I feel that setting up the test should be done in bzrlib code and
not in 'shell' code. If I wanted to do that, I would have used 'run_bzr'
everywhere.

But thanks for the review.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrwkAwACgkQJdeBCYSNAAN6lwCfS5vCl72+7xNIFd9hI7KxGy6t
VmQAn3HTairobpUxkkvKBgKZyW46zCvm
=/SJL
-----END PGP SIGNATURE-----