Code review comment for lp:~jameinel/bzr/1.19-bug-402778

On Tue, 2009-08-11 at 17:35 +0000, John A Meinel wrote:
> @@ -3816,10 +3818,13 @@
> parent_ids.difference_update(revision_ids)
> parent_ids.discard(_mod_revision.NULL_REVISION)
> parent_map = self.source.get_parent_map(parent_ids)
> - for parent_tree in self.source.revision_trees(parent_ids):
> - basis_id, delta = self._get_delta_for_revision(tree, parent_ids, basis_id, cache)
> + # we iterate over parent_map and not parent_ids because we don't
> + # want to try copying any revision which is a ghost
> + for parent_tree in self.source.revision_trees(parent_map.keys()):

This might be slightly cheaper as
+ for parent_tree in self.source.revision_trees(parent_map):

I'd prefer to see separate tests for ghosts and inventory validity.

so tweak:, however that is expressed...
 review +1