Code review comment for lp:~jameinel/bzr/1.19-bug-402778

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Wed, 2009-08-12 at 20:48 +0000, John A Meinel wrote:
>
>> Which is saying "I'm going to prune down to the minimum, and if the
>> source's number of keys is different than the minimum, then things have
>> changed."
>>
>> This means that reconcile on stacked branches is probably slightly wrong.
>>
>> But anyway, this change obviously doesn't effect reconcile :).
>
> Ok. So reconcile needs to keep the parent inventories too. I smell
> another branch coming up :).
>
> -Rob
>

Note that in that case --1.9 format repos are probably also vulnerable,
as I'm pretty sure Packer uses "self._revision_keys" directly, and
doesn't try to also include parent inventories.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqDMI8ACgkQJdeBCYSNAANyHQCeJ4DVIM/tuX1KbvnHDxMwQJrU
jMcAnAvAjV202VihITKOng43e4tYHqiz
=ExZL
-----END PGP SIGNATURE-----