Code review comment for lp:~jameinel/bzr/1.19-bug-402778

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Review: Approve
> review: +1
>
> The use of vf.keys() in the gc pack code - might want to check that
> reconcile() doesn't use revision selectors - as in that case you will
> copy too many inventories [if all tests are passing this probably isn't
> the case]
>
> -Rob
>

Reconcile has its own implementation of _copy_inventory_texts:

    def _copy_inventory_texts(self):
        source_vf, target_vf = self._build_vfs('inventory', True, True)
        self._copy_stream(source_vf, target_vf, self.revision_keys,
                          'inventories', self._get_filtered_inv_stream, 2)
        if source_vf.keys() != self.revision_keys:
            self._data_changed = True

Which is saying "I'm going to prune down to the minimum, and if the
source's number of keys is different than the minimum, then things have
changed."

This means that reconcile on stacked branches is probably slightly wrong.

But anyway, this change obviously doesn't effect reconcile :).

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqDKfUACgkQJdeBCYSNAAOuKQCeKD4PtKpnw6Ro0AZaWv/w0LPp
6woAoI/3kDA39hojP67PXDb715bJXIKU
=T66k
-----END PGP SIGNATURE-----