Code review comment for lp:~jameinel/bzr/1.16-simple-win32

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Thu, 2009-06-04 at 04:02 +0000, John A Meinel wrote:
>>> On Wed, 2009-06-03 at 20:45 +0000, John A Meinel wrote:
>>>> Sorry for the noise of Resubmit, but I wanted to regenerate the diff without
>>> including Vincent's patch.
>>>> To summarize, this simply adds a couple of quick fixes to skip certain tests
>>> that fail on Win32 with old format repositories.
>>>
>>> I can't see any new diff; the only thing I can see in this mp thread is
>>> the change to clarify key and fileid variables in a couple of tests -
>>> nothing that does 'skip'.
>>>
>>> -Rob
>>
>> I think you missed this part:
>> 21 + except errors.IllegalPath:
>> 22 + raise TestNotApplicable('file_id %r cannot be stored on this'
>> 23 + ' platform for this repo format' % (file_id,))
>
> Well, I'm looking at my mail client - I'm pretty sure that hasn't been
> in mail sent out. If its on the web UI only, then we should file a bug.
>
> -Rob
>

I see it in the email that was sent to me. I would assume you got the
same email.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkon6VcACgkQJdeBCYSNAAPk7ACdFfOCqe4D70cwWwaIozFYuMql
b4IAmwXyUNM/7Ryz3ATVAhB9DGXvu3Gn
=bSln
-----END PGP SIGNATURE-----