Merge lp:~jameinel/bzr-builddeb/no_revision_history into lp:bzr-builddeb
- no_revision_history
- Merge into trunk
Status: | Merged |
---|---|
Merged at revision: | 640 |
Proposed branch: | lp:~jameinel/bzr-builddeb/no_revision_history |
Merge into: | lp:bzr-builddeb |
Diff against target: |
382 lines (+87/-73) 3 files modified
tests/blackbox/test_import_dsc.py (+2/-2) tests/test_import_dsc.py (+81/-67) tests/test_merge_package.py (+4/-4) |
To merge this branch: | bzr merge lp:~jameinel/bzr-builddeb/no_revision_history |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij | Approve | ||
Review via email: mp+81149@code.launchpad.net |
Commit message
Don't use Branch.
Description of the change
This fixes bug #885690. We deprecated 'Branch.
I tried to fix as many of them as possible to use branch.
For some of them, I did go ahead and use the test_fetch approach, copying the 'revision_
This should be mostly mechanical, but you may want to read some of it closely to make sure I didn't change the meaning of any tests.
John A Meinel (jameinel) wrote : | # |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/03/2011 03:25 PM, Jelmer Vernooij wrote:
> Review: Approve
>
> I also had a branch which fixed some of these but that I hadn't
> proposed for merging yet...
>
> Anyway, yours is more thorough so let's merge that.
I can't commit directly. Can you land it?
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk6
nQ0AoLwqGqttkV0
=vVoL
-----END PGP SIGNATURE-----
Preview Diff
1 | === modified file 'tests/blackbox/test_import_dsc.py' | |||
2 | --- tests/blackbox/test_import_dsc.py 2011-07-19 15:05:54 +0000 | |||
3 | +++ tests/blackbox/test_import_dsc.py 2011-11-03 14:13:25 +0000 | |||
4 | @@ -113,7 +113,7 @@ | |||
5 | 113 | self.check_inventory_shape(tree.inventory, expected_shape) | 113 | self.check_inventory_shape(tree.inventory, expected_shape) |
6 | 114 | finally: | 114 | finally: |
7 | 115 | tree.unlock() | 115 | tree.unlock() |
9 | 116 | self.assertEqual(len(tree.branch.revision_history()), 3) | 116 | self.assertEqual(3, tree.branch.revno()) |
10 | 117 | 117 | ||
11 | 118 | def test_import_dsc(self): | 118 | def test_import_dsc(self): |
12 | 119 | self.requireFeature(PristineTarFeature) | 119 | self.requireFeature(PristineTarFeature) |
13 | @@ -130,7 +130,7 @@ | |||
14 | 130 | self.check_inventory_shape(tree.inventory, expected_shape) | 130 | self.check_inventory_shape(tree.inventory, expected_shape) |
15 | 131 | finally: | 131 | finally: |
16 | 132 | tree.unlock() | 132 | tree.unlock() |
18 | 133 | self.assertEqual(len(tree.branch.revision_history()), 2) | 133 | self.assertEqual(2, tree.branch.revno()) |
19 | 134 | 134 | ||
20 | 135 | def test_import_no_files(self): | 135 | def test_import_no_files(self): |
21 | 136 | self.make_branch_and_tree('.') | 136 | self.make_branch_and_tree('.') |
22 | 137 | 137 | ||
23 | === modified file 'tests/test_import_dsc.py' | |||
24 | --- tests/test_import_dsc.py 2011-10-13 18:05:08 +0000 | |||
25 | +++ tests/test_import_dsc.py 2011-11-03 14:13:25 +0000 | |||
26 | @@ -32,6 +32,7 @@ | |||
27 | 32 | from debian_bundle import deb822 | 32 | from debian_bundle import deb822 |
28 | 33 | 33 | ||
29 | 34 | from bzrlib import ( | 34 | from bzrlib import ( |
30 | 35 | revision as _mod_revision, | ||
31 | 35 | tests, | 36 | tests, |
32 | 36 | ) | 37 | ) |
33 | 37 | try: | 38 | try: |
34 | @@ -45,6 +46,19 @@ | |||
35 | 45 | SymlinkFeature, | 46 | SymlinkFeature, |
36 | 46 | ) | 47 | ) |
37 | 47 | 48 | ||
38 | 49 | ## Copied from bzrlib.tests.test_fetch from bzr-2.5 | ||
39 | 50 | def revision_history(branch): | ||
40 | 51 | branch.lock_read() | ||
41 | 52 | try: | ||
42 | 53 | graph = branch.repository.get_graph() | ||
43 | 54 | history = list(graph.iter_lefthand_ancestry(branch.last_revision(), | ||
44 | 55 | [_mod_revision.NULL_REVISION])) | ||
45 | 56 | finally: | ||
46 | 57 | branch.unlock() | ||
47 | 58 | history.reverse() | ||
48 | 59 | return history | ||
49 | 60 | |||
50 | 61 | |||
51 | 48 | from bzrlib.plugins.builddeb.import_dsc import ( | 62 | from bzrlib.plugins.builddeb.import_dsc import ( |
52 | 49 | DistributionBranch, | 63 | DistributionBranch, |
53 | 50 | DistributionBranchSet, | 64 | DistributionBranchSet, |
54 | @@ -794,11 +808,11 @@ | |||
55 | 794 | version = self.import_a_tree() | 808 | version = self.import_a_tree() |
56 | 795 | tree = self.up_tree1 | 809 | tree = self.up_tree1 |
57 | 796 | branch = tree.branch | 810 | branch = tree.branch |
60 | 797 | rh = branch.revision_history() | 811 | revno, rev_id = branch.last_revision_info() |
61 | 798 | self.assertEqual(len(rh), 1) | 812 | self.assertEqual(revno, 1) |
62 | 799 | self.assertEqual(self.db1.pristine_upstream_source.version_as_revisions( | 813 | self.assertEqual(self.db1.pristine_upstream_source.version_as_revisions( |
65 | 800 | "package", version.upstream_version), {None: rh[0]}) | 814 | "package", version.upstream_version), {None: rev_id}) |
66 | 801 | rev = branch.repository.get_revision(rh[0]) | 815 | rev = branch.repository.get_revision(rev_id) |
67 | 802 | self.assertEqual(rev.message, | 816 | self.assertEqual(rev.message, |
68 | 803 | "Import upstream version %s" % str(version.upstream_version)) | 817 | "Import upstream version %s" % str(version.upstream_version)) |
69 | 804 | self.assertEqual(rev.properties.get('deb-md5'), None) | 818 | self.assertEqual(rev.properties.get('deb-md5'), None) |
70 | @@ -832,18 +846,18 @@ | |||
71 | 832 | { None: [self.up_tree1.branch.last_revision()] }, [(None, None, None)]) | 846 | { None: [self.up_tree1.branch.last_revision()] }, [(None, None, None)]) |
72 | 833 | tree = self.up_tree1 | 847 | tree = self.up_tree1 |
73 | 834 | branch = tree.branch | 848 | branch = tree.branch |
76 | 835 | rh = branch.revision_history() | 849 | revno, rev_id = branch.last_revision_info() |
77 | 836 | self.assertEqual(len(rh), 2) | 850 | self.assertEqual(revno, 2) |
78 | 837 | self.assertEqual( | 851 | self.assertEqual( |
79 | 838 | self.db1.pristine_upstream_source.version_as_revisions( | 852 | self.db1.pristine_upstream_source.version_as_revisions( |
80 | 839 | "package", version2.upstream_version), | 853 | "package", version2.upstream_version), |
83 | 840 | {None: rh[1]}) | 854 | {None: rev_id}) |
84 | 841 | rev = branch.repository.get_revision(rh[1]) | 855 | rev = branch.repository.get_revision(rev_id) |
85 | 842 | self.assertEqual(rev.message, | 856 | self.assertEqual(rev.message, |
86 | 843 | "Import upstream version %s" % str(version2.upstream_version)) | 857 | "Import upstream version %s" % str(version2.upstream_version)) |
87 | 844 | self.assertIs(rev.properties.get('deb-md5'), None) | 858 | self.assertIs(rev.properties.get('deb-md5'), None) |
90 | 845 | rev_tree1 = branch.repository.revision_tree(rh[0]) | 859 | rev_tree1 = branch.repository.revision_tree(rev.parent_ids[0]) |
91 | 846 | rev_tree2 = branch.repository.revision_tree(rh[1]) | 860 | rev_tree2 = branch.repository.revision_tree(rev_id) |
92 | 847 | changes = rev_tree2.changes_from(rev_tree1) | 861 | changes = rev_tree2.changes_from(rev_tree1) |
93 | 848 | self.check_changes(changes, added=["NEWS"], removed=["COPYING"], | 862 | self.check_changes(changes, added=["NEWS"], removed=["COPYING"], |
94 | 849 | modified=["README"]) | 863 | modified=["README"]) |
95 | @@ -866,11 +880,11 @@ | |||
96 | 866 | upstream_tarballs=[(os.path.abspath(tar_path), None, self.fake_md5_1)]) | 880 | upstream_tarballs=[(os.path.abspath(tar_path), None, self.fake_md5_1)]) |
97 | 867 | tree = self.up_tree1 | 881 | tree = self.up_tree1 |
98 | 868 | branch = tree.branch | 882 | branch = tree.branch |
101 | 869 | rh = branch.revision_history() | 883 | revno, rev_id = branch.last_revision_info() |
102 | 870 | self.assertEqual(len(rh), 1) | 884 | self.assertEqual(revno, 1) |
103 | 871 | self.assertEqual(self.db1.pristine_upstream_source.version_as_revisions( | 885 | self.assertEqual(self.db1.pristine_upstream_source.version_as_revisions( |
106 | 872 | "package", version.upstream_version), {None: rh[0]}) | 886 | "package", version.upstream_version), {None: rev_id}) |
107 | 873 | rev = branch.repository.get_revision(rh[0]) | 887 | rev = branch.repository.get_revision(rev_id) |
108 | 874 | self.assertEqual(rev.message, | 888 | self.assertEqual(rev.message, |
109 | 875 | "Import upstream version %s" % str(version.upstream_version)) | 889 | "Import upstream version %s" % str(version.upstream_version)) |
110 | 876 | self.assertEqual(rev.properties['deb-md5'], self.fake_md5_1) | 890 | self.assertEqual(rev.properties['deb-md5'], self.fake_md5_1) |
111 | @@ -894,11 +908,11 @@ | |||
112 | 894 | {}, upstream_tarballs=[(os.path.abspath(tar_path), None, self.fake_md5_1)]) | 908 | {}, upstream_tarballs=[(os.path.abspath(tar_path), None, self.fake_md5_1)]) |
113 | 895 | tree = self.up_tree1 | 909 | tree = self.up_tree1 |
114 | 896 | branch = tree.branch | 910 | branch = tree.branch |
117 | 897 | rh = branch.revision_history() | 911 | revno, rev_id = branch.last_revision_info() |
118 | 898 | self.assertEqual(len(rh), 1) | 912 | self.assertEqual(revno, 1) |
119 | 899 | self.assertEqual(self.db1.pristine_upstream_source.version_as_revisions( | 913 | self.assertEqual(self.db1.pristine_upstream_source.version_as_revisions( |
122 | 900 | "package", version.upstream_version), {None: rh[0]}) | 914 | "package", version.upstream_version), {None: rev_id}) |
123 | 901 | rev = branch.repository.get_revision(rh[0]) | 915 | rev = branch.repository.get_revision(rev_id) |
124 | 902 | self.assertEqual(rev.message, | 916 | self.assertEqual(rev.message, |
125 | 903 | "Import upstream version %s" % str(version.upstream_version)) | 917 | "Import upstream version %s" % str(version.upstream_version)) |
126 | 904 | self.assertEqual(rev.properties['deb-md5'], self.fake_md5_1) | 918 | self.assertEqual(rev.properties['deb-md5'], self.fake_md5_1) |
127 | @@ -943,11 +957,11 @@ | |||
128 | 943 | {}, upstream_tarballs=[(os.path.abspath(tar_path), None, self.fake_md5_1)]) | 957 | {}, upstream_tarballs=[(os.path.abspath(tar_path), None, self.fake_md5_1)]) |
129 | 944 | tree = self.up_tree1 | 958 | tree = self.up_tree1 |
130 | 945 | branch = tree.branch | 959 | branch = tree.branch |
133 | 946 | rh = branch.revision_history() | 960 | revno, rev_id = branch.last_revision_info() |
134 | 947 | self.assertEqual(len(rh), 1) | 961 | self.assertEqual(revno, 1) |
135 | 948 | self.assertEqual(self.db1.pristine_upstream_source.version_as_revisions( | 962 | self.assertEqual(self.db1.pristine_upstream_source.version_as_revisions( |
138 | 949 | "package", version.upstream_version), {None: rh[0]}) | 963 | "package", version.upstream_version), {None: rev_id}) |
139 | 950 | rev = branch.repository.get_revision(rh[0]) | 964 | rev = branch.repository.get_revision(rev_id) |
140 | 951 | self.assertEqual(rev.message, | 965 | self.assertEqual(rev.message, |
141 | 952 | "Import upstream version %s" % str(version.upstream_version)) | 966 | "Import upstream version %s" % str(version.upstream_version)) |
142 | 953 | self.assertEqual(rev.properties['deb-md5'], self.fake_md5_1) | 967 | self.assertEqual(rev.properties['deb-md5'], self.fake_md5_1) |
143 | @@ -965,8 +979,8 @@ | |||
144 | 965 | builder.new_version(version2) | 979 | builder.new_version(version2) |
145 | 966 | builder.build() | 980 | builder.build() |
146 | 967 | self.db2.import_package(builder.dsc_name()) | 981 | self.db2.import_package(builder.dsc_name()) |
149 | 968 | self.assertEqual(len(self.up_tree2.branch.revision_history()), 2) | 982 | self.assertEqual(self.up_tree2.branch.revno(), 2) |
150 | 969 | self.assertEqual(len(self.tree2.branch.revision_history()), 3) | 983 | self.assertEqual(self.tree2.branch.revno(), 3) |
151 | 970 | 984 | ||
152 | 971 | def test_import_package_init_upstream_from_other(self): | 985 | def test_import_package_init_upstream_from_other(self): |
153 | 972 | self.requireFeature(PristineTarFeature) | 986 | self.requireFeature(PristineTarFeature) |
154 | @@ -980,8 +994,8 @@ | |||
155 | 980 | builder.new_version(version2) | 994 | builder.new_version(version2) |
156 | 981 | builder.build() | 995 | builder.build() |
157 | 982 | self.db1.import_package(builder.dsc_name()) | 996 | self.db1.import_package(builder.dsc_name()) |
160 | 983 | self.assertEqual(len(self.up_tree1.branch.revision_history()), 1) | 997 | self.assertEqual(self.up_tree1.branch.revno(), 1) |
161 | 984 | self.assertEqual(len(self.tree1.branch.revision_history()), 3) | 998 | self.assertEqual(self.tree1.branch.revno(), 3) |
162 | 985 | 999 | ||
163 | 986 | def import_package_single(self): | 1000 | def import_package_single(self): |
164 | 987 | version1 = Version("0.1-1") | 1001 | version1 = Version("0.1-1") |
165 | @@ -990,8 +1004,8 @@ | |||
166 | 990 | builder.add_default_control() | 1004 | builder.add_default_control() |
167 | 991 | builder.build() | 1005 | builder.build() |
168 | 992 | self.db1.import_package(builder.dsc_name()) | 1006 | self.db1.import_package(builder.dsc_name()) |
171 | 993 | self.assertEqual(len(self.up_tree1.branch.revision_history()), 1) | 1007 | self.assertEqual(self.up_tree1.branch.revno(), 1) |
172 | 994 | self.assertEqual(len(self.tree1.branch.revision_history()), 2) | 1008 | self.assertEqual(self.tree1.branch.revno(), 2) |
173 | 995 | 1009 | ||
174 | 996 | def test_import_package_double(self): | 1010 | def test_import_package_double(self): |
175 | 997 | self.requireFeature(PristineTarFeature) | 1011 | self.requireFeature(PristineTarFeature) |
176 | @@ -1016,8 +1030,8 @@ | |||
177 | 1016 | builder.remove_debian_file("COPYING") | 1030 | builder.remove_debian_file("COPYING") |
178 | 1017 | builder.build() | 1031 | builder.build() |
179 | 1018 | self.db1.import_package(builder.dsc_name()) | 1032 | self.db1.import_package(builder.dsc_name()) |
182 | 1019 | rh = self.tree1.branch.revision_history() | 1033 | rh = revision_history(self.tree1.branch) |
183 | 1020 | up_rh = self.up_tree1.branch.revision_history() | 1034 | up_rh = revision_history(self.up_tree1.branch) |
184 | 1021 | self.assertEqual(len(up_rh), 2) | 1035 | self.assertEqual(len(up_rh), 2) |
185 | 1022 | self.assertEqual(len(rh), 3) | 1036 | self.assertEqual(len(rh), 3) |
186 | 1023 | self.assertEqual(rh[0], up_rh[0]) | 1037 | self.assertEqual(rh[0], up_rh[0]) |
187 | @@ -1069,10 +1083,10 @@ | |||
188 | 1069 | builder.add_default_control() | 1083 | builder.add_default_control() |
189 | 1070 | builder.build() | 1084 | builder.build() |
190 | 1071 | self.db1.import_package(builder.dsc_name()) | 1085 | self.db1.import_package(builder.dsc_name()) |
195 | 1072 | rh1 = self.tree1.branch.revision_history() | 1086 | rh1 = revision_history(self.tree1.branch) |
196 | 1073 | rh2 = self.tree2.branch.revision_history() | 1087 | rh2 = revision_history(self.tree2.branch) |
197 | 1074 | up_rh1 = self.up_tree1.branch.revision_history() | 1088 | up_rh1 = revision_history(self.up_tree1.branch) |
198 | 1075 | up_rh2 = self.up_tree2.branch.revision_history() | 1089 | up_rh2 = revision_history(self.up_tree2.branch) |
199 | 1076 | self.assertEqual(len(rh1), 2) | 1090 | self.assertEqual(len(rh1), 2) |
200 | 1077 | self.assertEqual(len(rh2), 2) | 1091 | self.assertEqual(len(rh2), 2) |
201 | 1078 | self.assertEqual(len(up_rh1), 1) | 1092 | self.assertEqual(len(up_rh1), 1) |
202 | @@ -1118,10 +1132,10 @@ | |||
203 | 1118 | builder.build() | 1132 | builder.build() |
204 | 1119 | self.db1.import_package(builder.dsc_name()) | 1133 | self.db1.import_package(builder.dsc_name()) |
205 | 1120 | self.db2.import_package(builder.dsc_name()) | 1134 | self.db2.import_package(builder.dsc_name()) |
210 | 1121 | rh1 = self.tree1.branch.revision_history() | 1135 | rh1 = revision_history(self.tree1.branch) |
211 | 1122 | rh2 = self.tree2.branch.revision_history() | 1136 | rh2 = revision_history(self.tree2.branch) |
212 | 1123 | up_rh1 = self.up_tree1.branch.revision_history() | 1137 | up_rh1 = revision_history(self.up_tree1.branch) |
213 | 1124 | up_rh2 = self.up_tree2.branch.revision_history() | 1138 | up_rh2 = revision_history(self.up_tree2.branch) |
214 | 1125 | self.assertEqual(len(rh1), 3) | 1139 | self.assertEqual(len(rh1), 3) |
215 | 1126 | self.assertEqual(len(rh2), 4) | 1140 | self.assertEqual(len(rh2), 4) |
216 | 1127 | self.assertEqual(len(up_rh1), 2) | 1141 | self.assertEqual(len(up_rh1), 2) |
217 | @@ -1161,10 +1175,10 @@ | |||
218 | 1161 | builder.build() | 1175 | builder.build() |
219 | 1162 | self.db1.import_package(builder.dsc_name()) | 1176 | self.db1.import_package(builder.dsc_name()) |
220 | 1163 | self.db2.import_package(builder.dsc_name()) | 1177 | self.db2.import_package(builder.dsc_name()) |
225 | 1164 | self.assertEqual(3, len(self.tree1.branch.revision_history())) | 1178 | self.assertEqual(3, self.tree1.branch.revno()) |
226 | 1165 | self.assertEqual(2, len(self.up_tree1.branch.revision_history())) | 1179 | self.assertEqual(2, self.up_tree1.branch.revno()) |
227 | 1166 | self.assertEqual(3, len(self.tree2.branch.revision_history())) | 1180 | self.assertEqual(3, self.tree2.branch.revno()) |
228 | 1167 | self.assertEqual(2, len(self.up_tree2.branch.revision_history())) | 1181 | self.assertEqual(2, self.up_tree2.branch.revno()) |
229 | 1168 | self.assertEqual(self.tree1.last_revision(), | 1182 | self.assertEqual(self.tree1.last_revision(), |
230 | 1169 | self.tree2.last_revision()) | 1183 | self.tree2.last_revision()) |
231 | 1170 | self.assertEqual(self.up_tree1.last_revision(), | 1184 | self.assertEqual(self.up_tree1.last_revision(), |
232 | @@ -1188,14 +1202,14 @@ | |||
233 | 1188 | builder.add_default_control() | 1202 | builder.add_default_control() |
234 | 1189 | builder.build() | 1203 | builder.build() |
235 | 1190 | self.db1.import_package(builder.dsc_name()) | 1204 | self.db1.import_package(builder.dsc_name()) |
240 | 1191 | rh1 = self.tree1.branch.revision_history() | 1205 | revno1, rev_id1 = self.tree1.branch.last_revision_info() |
241 | 1192 | up_rh1 = self.up_tree1.branch.revision_history() | 1206 | up_revno1, up_rev_id1 = self.up_tree1.branch.last_revision_info() |
242 | 1193 | self.assertEqual(len(rh1), 1) | 1207 | self.assertEqual(revno1, 1) |
243 | 1194 | self.assertEqual(len(up_rh1), 0) | 1208 | self.assertEqual(up_revno1, 0) |
244 | 1195 | self.tree1.lock_read() | 1209 | self.tree1.lock_read() |
245 | 1196 | self.addCleanup(self.tree1.unlock) | 1210 | self.addCleanup(self.tree1.unlock) |
246 | 1197 | self.assertTrue(self.db1.is_version_native(version)) | 1211 | self.assertTrue(self.db1.is_version_native(version)) |
248 | 1198 | revtree = self.tree1.branch.repository.revision_tree(rh1[0]) | 1212 | revtree = self.tree1.branch.repository.revision_tree(rev_id1) |
249 | 1199 | config_fileid, current_config = self.db1._default_config_for_tree(revtree) | 1213 | config_fileid, current_config = self.db1._default_config_for_tree(revtree) |
250 | 1200 | self.assertTrue(self.db1._is_tree_native(current_config)) | 1214 | self.assertTrue(self.db1._is_tree_native(current_config)) |
251 | 1201 | 1215 | ||
252 | @@ -1214,8 +1228,8 @@ | |||
253 | 1214 | builder.add_debian_file("NEWS") | 1228 | builder.add_debian_file("NEWS") |
254 | 1215 | builder.build() | 1229 | builder.build() |
255 | 1216 | self.db1.import_package(builder.dsc_name()) | 1230 | self.db1.import_package(builder.dsc_name()) |
258 | 1217 | rh1 = self.tree1.branch.revision_history() | 1231 | rh1 = revision_history(self.tree1.branch) |
259 | 1218 | up_rh1 = self.up_tree1.branch.revision_history() | 1232 | up_rh1 = revision_history(self.up_tree1.branch) |
260 | 1219 | self.assertEqual(len(rh1), 2) | 1233 | self.assertEqual(len(rh1), 2) |
261 | 1220 | self.assertEqual(len(up_rh1), 0) | 1234 | self.assertEqual(len(up_rh1), 0) |
262 | 1221 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[0]) | 1235 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[0]) |
263 | @@ -1245,8 +1259,8 @@ | |||
264 | 1245 | builder.add_upstream_file("README", "bar") | 1259 | builder.add_upstream_file("README", "bar") |
265 | 1246 | builder.build() | 1260 | builder.build() |
266 | 1247 | self.db1.import_package(builder.dsc_name()) | 1261 | self.db1.import_package(builder.dsc_name()) |
269 | 1248 | rh1 = self.tree1.branch.revision_history() | 1262 | rh1 = revision_history(self.tree1.branch) |
270 | 1249 | up_rh1 = self.up_tree1.branch.revision_history() | 1263 | up_rh1 = revision_history(self.up_tree1.branch) |
271 | 1250 | self.assertEqual(len(rh1), 2) | 1264 | self.assertEqual(len(rh1), 2) |
272 | 1251 | self.assertEqual(len(up_rh1), 0) | 1265 | self.assertEqual(len(up_rh1), 0) |
273 | 1252 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[0]) | 1266 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[0]) |
274 | @@ -1280,8 +1294,8 @@ | |||
275 | 1280 | builder.add_upstream_file("NEWS") | 1294 | builder.add_upstream_file("NEWS") |
276 | 1281 | builder.build() | 1295 | builder.build() |
277 | 1282 | self.db1.import_package(builder.dsc_name()) | 1296 | self.db1.import_package(builder.dsc_name()) |
280 | 1283 | rh1 = self.tree1.branch.revision_history() | 1297 | rh1 = revision_history(self.tree1.branch) |
281 | 1284 | up_rh1 = self.up_tree1.branch.revision_history() | 1298 | up_rh1 = revision_history(self.up_tree1.branch) |
282 | 1285 | self.assertEqual(len(rh1), 3) | 1299 | self.assertEqual(len(rh1), 3) |
283 | 1286 | self.assertEqual(len(up_rh1), 1) | 1300 | self.assertEqual(len(up_rh1), 1) |
284 | 1287 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[1]) | 1301 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[1]) |
285 | @@ -1316,8 +1330,8 @@ | |||
286 | 1316 | builder.add_upstream_file("NEWS") | 1330 | builder.add_upstream_file("NEWS") |
287 | 1317 | builder.build() | 1331 | builder.build() |
288 | 1318 | self.db1.import_package(builder.dsc_name()) | 1332 | self.db1.import_package(builder.dsc_name()) |
291 | 1319 | rh1 = self.tree1.branch.revision_history() | 1333 | rh1 = revision_history(self.tree1.branch) |
292 | 1320 | up_rh1 = self.up_tree1.branch.revision_history() | 1334 | up_rh1 = revision_history(self.up_tree1.branch) |
293 | 1321 | self.assertEqual(len(rh1), 2) | 1335 | self.assertEqual(len(rh1), 2) |
294 | 1322 | self.assertEqual(len(up_rh1), 2) | 1336 | self.assertEqual(len(up_rh1), 2) |
295 | 1323 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[0]) | 1337 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[0]) |
296 | @@ -1369,8 +1383,8 @@ | |||
297 | 1369 | builder.new_version(version3) | 1383 | builder.new_version(version3) |
298 | 1370 | builder.build() | 1384 | builder.build() |
299 | 1371 | self.db1.import_package(builder.dsc_name()) | 1385 | self.db1.import_package(builder.dsc_name()) |
302 | 1372 | rh1 = self.tree1.branch.revision_history() | 1386 | rh1 = revision_history(self.tree1.branch) |
303 | 1373 | up_rh1 = self.up_tree1.branch.revision_history() | 1387 | up_rh1 = revision_history(self.up_tree1.branch) |
304 | 1374 | self.assertEqual(len(rh1), 4) | 1388 | self.assertEqual(len(rh1), 4) |
305 | 1375 | self.assertEqual(len(up_rh1), 1) | 1389 | self.assertEqual(len(up_rh1), 1) |
306 | 1376 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[1]) | 1390 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[1]) |
307 | @@ -1418,8 +1432,8 @@ | |||
308 | 1418 | builder.new_version(version3) | 1432 | builder.new_version(version3) |
309 | 1419 | builder.build() | 1433 | builder.build() |
310 | 1420 | self.db1.import_package(builder.dsc_name()) | 1434 | self.db1.import_package(builder.dsc_name()) |
313 | 1421 | rh1 = self.tree1.branch.revision_history() | 1435 | rh1 = revision_history(self.tree1.branch) |
314 | 1422 | up_rh1 = self.up_tree1.branch.revision_history() | 1436 | up_rh1 = revision_history(self.up_tree1.branch) |
315 | 1423 | self.assertEqual(len(rh1), 4) | 1437 | self.assertEqual(len(rh1), 4) |
316 | 1424 | self.assertEqual(len(up_rh1), 2) | 1438 | self.assertEqual(len(up_rh1), 2) |
317 | 1425 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[1]) | 1439 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[1]) |
318 | @@ -1475,8 +1489,8 @@ | |||
319 | 1475 | builder.new_version(version3) | 1489 | builder.new_version(version3) |
320 | 1476 | builder.build() | 1490 | builder.build() |
321 | 1477 | self.db1.import_package(builder.dsc_name()) | 1491 | self.db1.import_package(builder.dsc_name()) |
324 | 1478 | rh1 = self.tree1.branch.revision_history() | 1492 | rh1 = revision_history(self.tree1.branch) |
325 | 1479 | up_rh1 = self.up_tree1.branch.revision_history() | 1493 | up_rh1 = revision_history(self.up_tree1.branch) |
326 | 1480 | self.assertEqual(len(rh1), 4) | 1494 | self.assertEqual(len(rh1), 4) |
327 | 1481 | self.assertEqual(len(up_rh1), 2) | 1495 | self.assertEqual(len(up_rh1), 2) |
328 | 1482 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[1]) | 1496 | rev_tree1 = self.tree1.branch.repository.revision_tree(rh1[1]) |
329 | @@ -1528,10 +1542,10 @@ | |||
330 | 1528 | builder.build() | 1542 | builder.build() |
331 | 1529 | self.db1.import_package(builder.dsc_name()) | 1543 | self.db1.import_package(builder.dsc_name()) |
332 | 1530 | self.db2.import_package(builder.dsc_name()) | 1544 | self.db2.import_package(builder.dsc_name()) |
337 | 1531 | rh1 = self.tree1.branch.revision_history() | 1545 | rh1 = revision_history(self.tree1.branch) |
338 | 1532 | up_rh1 = self.up_tree1.branch.revision_history() | 1546 | up_rh1 = revision_history(self.up_tree1.branch) |
339 | 1533 | rh2 = self.tree2.branch.revision_history() | 1547 | rh2 = revision_history(self.tree2.branch) |
340 | 1534 | up_rh2 = self.up_tree2.branch.revision_history() | 1548 | up_rh2 = revision_history(self.up_tree2.branch) |
341 | 1535 | self.assertEqual(3, len(rh1)) | 1549 | self.assertEqual(3, len(rh1)) |
342 | 1536 | self.assertEqual(2, len(up_rh1)) | 1550 | self.assertEqual(2, len(up_rh1)) |
343 | 1537 | self.assertEqual(4, len(rh2)) | 1551 | self.assertEqual(4, len(rh2)) |
344 | @@ -1694,8 +1708,8 @@ | |||
345 | 1694 | version1.upstream_version, | 1708 | version1.upstream_version, |
346 | 1695 | upstream_branch=upstream_tree.branch, | 1709 | upstream_branch=upstream_tree.branch, |
347 | 1696 | upstream_revisions={None: upstream_rev}) | 1710 | upstream_revisions={None: upstream_rev}) |
350 | 1697 | rh1 = tree.branch.revision_history() | 1711 | revno1, rev_id1 = tree.branch.last_revision_info() |
351 | 1698 | self.assertEqual(2, len(rh1)) | 1712 | self.assertEqual(2, revno1) |
352 | 1699 | packaging_upstream_tip = tree.get_parent_ids()[1] | 1713 | packaging_upstream_tip = tree.get_parent_ids()[1] |
353 | 1700 | # We added the extra parent for the upstream branch | 1714 | # We added the extra parent for the upstream branch |
354 | 1701 | revtree = tree.branch.repository.revision_tree(packaging_upstream_tip) | 1715 | revtree = tree.branch.repository.revision_tree(packaging_upstream_tip) |
355 | 1702 | 1716 | ||
356 | === modified file 'tests/test_merge_package.py' | |||
357 | --- tests/test_merge_package.py 2011-06-26 21:18:23 +0000 | |||
358 | +++ tests/test_merge_package.py 2011-11-03 14:13:25 +0000 | |||
359 | @@ -126,11 +126,11 @@ | |||
360 | 126 | self.assertEqual(db1.pristine_upstream_source.has_version("package", v4), False) | 126 | self.assertEqual(db1.pristine_upstream_source.has_version("package", v4), False) |
361 | 127 | 127 | ||
362 | 128 | # The ubuntu upstream branch tip. | 128 | # The ubuntu upstream branch tip. |
364 | 129 | ubuu_tip = ubuu.branch.revision_history()[-1] | 129 | ubuu_tip = ubuu.branch.last_revision() |
365 | 130 | # The debian upstream branch tip. | 130 | # The debian upstream branch tip. |
367 | 131 | debu_tip = debu.branch.revision_history()[-1] | 131 | debu_tip = debu.branch.last_revision() |
368 | 132 | # The ubuntu packaging branch tip. | 132 | # The ubuntu packaging branch tip. |
370 | 133 | ubup_tip_pre_fix = ubup.branch.revision_history()[-1] | 133 | ubup_tip_pre_fix = ubup.branch.last_revision() |
371 | 134 | 134 | ||
372 | 135 | # The first conflict is resolved by calling fix_ancestry_as_needed(). | 135 | # The first conflict is resolved by calling fix_ancestry_as_needed(). |
373 | 136 | upstreams_diverged, t_upstream_reverted = MP.fix_ancestry_as_needed(ubup, debp.branch) | 136 | upstreams_diverged, t_upstream_reverted = MP.fix_ancestry_as_needed(ubup, debp.branch) |
374 | @@ -150,7 +150,7 @@ | |||
375 | 150 | self.assertEqual(db2.pristine_upstream_source.has_version("package", v4), True) | 150 | self.assertEqual(db2.pristine_upstream_source.has_version("package", v4), True) |
376 | 151 | 151 | ||
377 | 152 | # Now let's take a look at the fixed ubuntu packaging branch. | 152 | # Now let's take a look at the fixed ubuntu packaging branch. |
379 | 153 | ubup_tip_post_fix = ubup.branch.revision_history()[-1] | 153 | ubup_tip_post_fix = ubup.branch.last_revision() |
380 | 154 | ubup_parents_post_fix = ubup.branch.repository.revision_tree(ubup_tip_post_fix).get_parent_ids() | 154 | ubup_parents_post_fix = ubup.branch.repository.revision_tree(ubup_tip_post_fix).get_parent_ids() |
381 | 155 | 155 | ||
382 | 156 | # The tip of the fixed ubuntu packaging branch has 2 parents. | 156 | # The tip of the fixed ubuntu packaging branch has 2 parents. |
I also had a branch which fixed some of these but that I hadn't proposed for merging yet...
Anyway, yours is more thorough so let's merge that.