Merge lp:~jamalta/unity/677255-unity-fullscreen into lp:unity

Proposed by Jamal Fanaian
Status: Rejected
Rejected by: Didier Roche-Tolomelli
Proposed branch: lp:~jamalta/unity/677255-unity-fullscreen
Merge into: lp:unity
Diff against target: 13 lines (+2/-1)
1 file modified
src/unity.cpp (+2/-1)
To merge this branch: bzr merge lp:~jamalta/unity/677255-unity-fullscreen
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Abstain
Jamal Fanaian (community) Disapprove
Review via email: mp+41558@code.launchpad.net

Description of the change

Don't redraw over window type CompWindowTypeFullscreenMask.

To post a comment you must log in.
Revision history for this message
Omer Akram (om26er) wrote :

does not apply to current trunk anymore.

Revision history for this message
Jamal Fanaian (jamalta) wrote :

It looks like this bug was fixed and awaiting to be merged by the time I started working on it. I saw it go into trunk a day or so after I posted this and forgot to close the MP.

Thanks for your input!

review: Disapprove
Revision history for this message
Omer Akram (om26er) wrote :

i dont think its fixed. only the screensaver case was fixed fullscreen apps still show panel and the launcher. so you can work on this if you have the time ;)

Revision history for this message
Neil J. Patel (njpatel) :
review: Abstain
Revision history for this message
Neil J. Patel (njpatel) :
review: Abstain
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Syncing the state to rejected to clean the list (the fix is far deprecated :))

Unmerged revisions

620. By Jamal Fanaian

Don't paint over fullscreen window.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/unity.cpp'
--- src/unity.cpp 2010-11-15 23:07:58 +0000
+++ src/unity.cpp 2010-11-23 07:20:53 +0000
@@ -263,7 +263,8 @@
263 CompWindowTypePopupMenuMask |263 CompWindowTypePopupMenuMask |
264 CompWindowTypeComboMask |264 CompWindowTypeComboMask |
265 CompWindowTypeTooltipMask |265 CompWindowTypeTooltipMask |
266 CompWindowTypeDndMask266 CompWindowTypeDndMask |
267 CompWindowTypeFullscreenMask
267 ))268 ))
268 {269 {
269 uScreen->paintDisplay (region);270 uScreen->paintDisplay (region);