Code review comment for lp:~jamalta/launchpad/bug-127489

Revision history for this message
Guilherme Salgado (salgado) wrote :

On Fri, 2009-09-18 at 00:45 +0000, Jamal Fanaian wrote:
> Thanks for your comments. I have made the modifications as you
> requested. I ran `make lint` but it didn't tell me I had any unused
> libraries. I proceeded to double-check by hand and I am using all the
> included libraries. Please let me know if this is incorrect.

Indeed; I thought your test was not using LaunchpadTestRequest but it
is. I'll submit your changes on your behalf.

 status approved

--
Guilherme Salgado <email address hidden>

review: Approve

« Back to merge proposal