Code review comment for lp:~jakedahn/nova/os-quotas

Revision history for this message
Anthony Young (sleepsonthefloor) wrote :

Few comments:

* I think it makes sense to use the name QuotaSetsController, to match resource quota_set.
* not sure if index doesn't makes sense for this controller (with keystone). perhaps ditch the listing, and move the get defaults functionality to an action?
* Probably should explicitly check for admin-ness (except for the get defaults)

Note that this controller mixes user and admin functionality - I guess that is ok since there seems to be no precedent for separating user/admin functionality by controller. Anyone else have opinions about where user vs. admin functionality should live in general?

review: Needs Fixing

« Back to merge proposal