Merge lp:~jakedahn/horizon/dashboard-508-fixes into lp:~hudson-openstack/horizon/trunk

Proposed by Jake Dahn
Status: Merged
Approved by: Devin Carlen
Approved revision: 31
Merged at revision: 30
Proposed branch: lp:~jakedahn/horizon/dashboard-508-fixes
Merge into: lp:~hudson-openstack/horizon/trunk
Diff against target: 36 lines (+5/-4)
2 files modified
django-nova/src/django_nova/templates/django_nova/images/launch.html (+1/-1)
django-nova/src/django_nova/templates/django_nova/projects/edit_user.html (+4/-3)
To merge this branch: bzr merge lp:~jakedahn/horizon/dashboard-508-fixes
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email: mp+55646@code.launchpad.net

Description of the change

This branch fixes inconsistencies which were causing errors and breaking section 508 compatibility.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'django-nova/src/django_nova/templates/django_nova/images/launch.html'
2--- django-nova/src/django_nova/templates/django_nova/images/launch.html 2011-03-09 10:02:34 +0000
3+++ django-nova/src/django_nova/templates/django_nova/images/launch.html 2011-03-30 22:18:58 +0000
4@@ -19,7 +19,7 @@
5 <fieldset>
6 <h3 class="image_id">Launch Image {{ ami.id }}</h3>
7 <div class="even">
8- <label>Location</label>
9+ <h4 class="label">Location</h4>
10 <span class="image_location">{{ ami.location }}</span>
11 </div>
12 {% include "django_nova/images/_launch_form.html" %}
13
14=== modified file 'django-nova/src/django_nova/templates/django_nova/projects/edit_user.html'
15--- django-nova/src/django_nova/templates/django_nova/projects/edit_user.html 2011-03-03 01:20:17 +0000
16+++ django-nova/src/django_nova/templates/django_nova/projects/edit_user.html 2011-03-30 22:18:58 +0000
17@@ -33,15 +33,16 @@
18 <fieldset class="module aligned {{ fieldset.classes }}">
19 <h3 id="edit_{{ user.username }}">Edit Roles for User: {{ user.username }}</h3>
20 <div class="form-row">
21- <label>User</label>
22+ <h4 class="label">User</h4>
23 <span id="user_name">{{ user.username }}</span>
24 </div>
25 <input type="hidden" name="username" value="{{ user.id }}" id="username" />
26-
27+
28+ <label for="id_role_from">Roles</label>
29 {% for field in form.visible_fields %}
30 <div class="form-row">
31 {{ field.errors }}
32- {{ field.label_tag }}{{ field }}
33+ {{ field }}
34 {% if field.field.help_text %}<p class="help">{{ field.field.help_text|safe }}</p>{% endif %}
35 </div>
36 {% endfor %}

Subscribers

People subscribed via source and target branches