Merge lp:~jakedahn/horizon/760072 into lp:~hudson-openstack/horizon/trunk

Proposed by Jake Dahn
Status: Merged
Approved by: Devin Carlen
Approved revision: 32
Merged at revision: 34
Proposed branch: lp:~jakedahn/horizon/760072
Merge into: lp:~hudson-openstack/horizon/trunk
Diff against target: 74 lines (+16/-5)
3 files modified
django-nova/src/django_nova/templates/django_nova/images/_list.html (+4/-3)
django-nova/src/django_nova/views/images.py (+1/-1)
openstack-dashboard/media/dashboard/css/openstack.css (+11/-1)
To merge this branch: bzr merge lp:~jakedahn/horizon/760072
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email: mp+57567@code.launchpad.net

Description of the change

Added close link to the image detail ui, so users do not have to go to the main navigation to return to the standard image list.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'django-nova/src/django_nova/templates/django_nova/images/_list.html'
2--- django-nova/src/django_nova/templates/django_nova/images/_list.html 2011-03-18 01:25:14 +0000
3+++ django-nova/src/django_nova/templates/django_nova/images/_list.html 2011-04-13 19:16:35 +0000
4@@ -21,7 +21,7 @@
5 <span class="data">{{ ami.description }}</span>
6 </div>
7
8- <div class="image_detail_item">
9+ <div id="location" class="image_detail_item">
10 <span class="label">Location: </span>
11 <span class="data">{{ ami.location }}</span>
12 </div>
13@@ -59,7 +59,8 @@
14 {% endif %}
15
16 </div>
17-
18+ <a id="close_detail" href="{% url nova_images project.projectname %}">[x] close</a>
19+
20 {% if user.username == ami.ownerId %}
21 <span class="image_privacy">
22 <form id="privacy_{{ ami.id }}" action="{% url nova_images_privacy project.projectname ami.id %}" method="post" accept-charset="utf-8">
23@@ -78,7 +79,7 @@
24 <input type="submit" value="Remove Image" />
25 </form>
26 </span>
27- {% endif %}
28+ {% endif %}
29 </div>
30 </td>
31 {% else %}
32
33=== modified file 'django-nova/src/django_nova/views/images.py'
34--- django-nova/src/django_nova/views/images.py 2011-03-18 01:25:14 +0000
35+++ django-nova/src/django_nova/views/images.py 2011-04-13 19:16:35 +0000
36@@ -33,7 +33,7 @@
37 from django_nova import forms
38 from django_nova import shortcuts
39 from django_nova.exceptions import handle_nova_error
40-
41+from django_nova.urls import project
42
43 def _image_lists(images, project_id):
44 def image_is_project(i):
45
46=== modified file 'openstack-dashboard/media/dashboard/css/openstack.css'
47--- openstack-dashboard/media/dashboard/css/openstack.css 2011-03-30 04:47:34 +0000
48+++ openstack-dashboard/media/dashboard/css/openstack.css 2011-04-13 19:16:35 +0000
49@@ -603,7 +603,7 @@
50 margin: -25px 0 0 0px !important;
51 }
52
53-.image_detail .delete input, #user_edit .deletelink, #update_profile input[type="reset"], .image_detail .image_privacy input, .instance_detail .form-terminate input[type="submit"], .cancel a {
54+.image_detail .delete input, #user_edit .deletelink, #update_profile input[type="reset"], .image_detail .image_privacy input, .instance_detail .form-terminate input[type="submit"], .cancel a, #image_launch .image_detail a#close_detail {
55 background: none;
56 border: none;
57 color: #FF8885;
58@@ -616,6 +616,16 @@
59 color: red;
60 }
61
62+#location .data {
63+ width: 180px;
64+}
65+
66+#close_detail {
67+ float: left;
68+ margin-top: -4px !important;
69+ margin-right: 10px;
70+}
71+
72 .cancel {
73 margin-top: 5px;
74 float: left;

Subscribers

People subscribed via source and target branches