Code review comment for lp:~jacekn/charms/precise/rabbitmq-server/queue-monitoring

Jacek,

Thank you for resubmitting this proposal with those fixes!

I deployed the charms as listed above and added the text (from your last comment) to the juju-hp-mbruzek-machine-1_queue_stats.dat file:
sudo vi juju-hp-mbruzek-machine-1_queue_stats.dat

The check_rabbitmq_queues.py still does not return any output! I am using hp-cloud but the output is essentially the same:
ubuntu@juju-hp-mbruzek-machine-1:~$ /usr/local/lib/nagios/plugins/check_rabbitmq_queues.py -c \* \* 15 30 /var/lib/rabbitmq/data/*_queue_stats.dat
CRITICALS: No Queues Found in No Vhosts Found has None messages

Also there are 2 new keys that need default: in config.yaml.
$ charm proof
W: config.yaml: option key does not have the keys: default
W: config.yaml: option source does not have the keys: default

These configuration options need the “default:” keyword in the config.yaml and my understanding is leaving them blank gives it a None value which is what I recommend for these options.

The rabbitmq queue has not filled up on any of the tests with the rabbitmq-server and nrpe-external-master charms deployed. Please provide detailed steps on how to set this charm up so the rabbitmq queue starts filling up so we can verify the Merge Proposal!

Putting this proposal in "Needs Fixing". Once you have addressed the issues please click on the “Request another review” link on this merge proposal. That way it will be added to the review queue properly.

If you have any questions/comments/concerns about the review contact mbruzek on IRC. You can find the rest of the team in #juju on irc.freenode.net or email the mailing list <email address hidden>