Code review comment for lp:~jacekn/charms/precise/rabbitmq-server/queue-monitoring

Revision history for this message
Jacek Nykis (jacekn) wrote :

Hi Matt,

Thank you for reviewing the charm. I added default values (empty strings) and tested everything again.

If you want to verify the queue check you can use sample data below. This lines were generated by the same script as one in the charm. You can also modify 5th column to simulate queues filling up.

#Vhost Name Messages_ready Messages_unacknowledged Messages Consumers Memory Time
nagios-rabbitmq-server-0 test_exchange_queue 0 0 0 0 8952 1401271802
openstack ceilometer.collector 0 0 0 1 13984 1401271802
openstack ceilometer.collector.metering 0 0 0 1 14056 1401271802
openstack cert 0 0 0 1 13984 1401271802

review: Needs Resubmitting

« Back to merge proposal