Code review comment for lp:~jacekn/charms/precise/rabbitmq-server/queue-monitoring

Jacek,

Thanks for this work on the rabbitmq-server! I realize monitoring is important for production environments and am looking forward to getting the monitoring code in the charm.

When I run charm proof on the merged code there are two new Warning messages:
$ charm proof
W: config.yaml: option stats_cron_schedule does not have the keys: default
W: config.yaml: option queue_thresholds does not have the keys: default
…

These new configuration values should have default values in the config.yaml file. You can have a default of “” or (I believe) NoneType is valid.

Thanks for chatting with me on IRC. The steps to test this were as follows:

juju deploy --repository=. local:precise/rabbitmq-server
juju deploy nrpe-external-master
juju add-relation rabbitmq-server nrpe-external-master

juju set rabbitmq-server stats_cron_schedule="*/5 * * * *"
juju set rabbitmq-server queue_thresholds="[['\*', '\*', 15, 30]]"

(Wait 5 minutes for the queue data to be generated by cron")
juju ssh rabbitmq-server/0
$ /usr/local/lib/nagios/plugins/check_rabbitmq_queues.py -c \* \* 15 30 /var/lib/rabbitmq/data/*_queue_stats.dat

The result of this command were:
ubuntu@mbruzek-local-machine-1:/var/lib/rabbitmq/data$ /usr/local/lib/nagios/plugins/check_rabbitmq_queues.py -c \* \* 15 30 /var/lib/rabbitmq/data/mbruzek-local-machine-1_queue_stats.dat
CRITICALS: No Queues Found in No Vhosts Found has None messages

Normally this result would indicate a failure, but you mentioned on IRC that is to be expected because there was nothing connected to rabbitmq-server to generate messages. I was unable to figure out how to generate queued messages in rabbitmq-server for further testing.

Please provide default values for the two new configuration options and give me some more details on how to generate some rabbitmq-traffic so we can see the command run successful.

Thank you again for the submission! I am going to put this MP to "needs fixing"

Once the problem has been addressed, click on the “Request another review” link on this merge proposal. That way it will be added to the review queue properly.

If you have any questions/comments/concerns about the review contact mbruzek on IRC. You can find the rest of the team in #juju on irc.freenode.net or email the mailing list <email address hidden>