Code review comment for lp:~jacekn/charm-helpers/charm-helpers-ssl

Revision history for this message
Matthew Wedgwood (mew) wrote :

I'm able to get the new function succeed using the "cn" parameter, but it explodes[1] when I try to use "subject." I've tried that one with various permutations on the keys included in the dict. I haven't tested the "config" parameter.

Also, I notice you're returning False for failures, but when the function actually succeeds, it returns None. You might want an explicit "return True" at the end.

[1] http://pastebin.ubuntu.com/6034287/

review: Needs Fixing

« Back to merge proposal