Merge lp:~jaapz-b/slingshot/monitorposition into lp:~elementary-pantheon/slingshot/trunk

Proposed by Jaap Broekhuizen
Status: Merged
Merged at revision: 126
Proposed branch: lp:~jaapz-b/slingshot/monitorposition
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 36 lines (+19/-1)
1 file modified
src/SlingshotView.vala (+19/-1)
To merge this branch: bzr merge lp:~jaapz-b/slingshot/monitorposition
Reviewer Review Type Date Requested Status
Fabian Thoma Approve
Review via email: mp+88579@code.launchpad.net

Description of the change

The monitor position bug (#909502) is fixed in this branch

To post a comment you must log in.
Revision history for this message
Fabian Thoma (fabianthoma) wrote :

Tested code, and works perfectly fine, merging it

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/SlingshotView.vala'
--- src/SlingshotView.vala 2011-11-27 16:25:34 +0000
+++ src/SlingshotView.vala 2012-01-14 14:37:24 +0000
@@ -224,6 +224,24 @@
224224
225 });225 });
226226
227 // position on the right monitor when settings changed
228 screen.size_changed.connect (() => {
229 reposition ();
230 });
231 screen.monitors_changed.connect (() => {
232 reposition ();
233 });
234
235 }
236
237 private void reposition () {
238
239 debug("Repositioning");
240
241 Gdk.Rectangle monitor_dimensions;
242 screen.get_monitor_geometry (this.screen.get_primary_monitor(), out monitor_dimensions);
243
244 move_to_coords (monitor_dimensions.x, monitor_dimensions.y); //this would be coordinates 0,0 on the screen
227 }245 }
228246
229 public override bool key_press_event (Gdk.EventKey event) {247 public override bool key_press_event (Gdk.EventKey event) {
@@ -438,7 +456,7 @@
438456
439 public void show_slingshot () {457 public void show_slingshot () {
440458
441 move_to_coords (0, 0);459 reposition ();
442 show_all ();460 show_all ();
443 set_modality ((Modality) view_selector.selected);461 set_modality ((Modality) view_selector.selected);
444462

Subscribers

People subscribed via source and target branches