Merge lp:~j-corwin/openlp/presentations into lp:openlp

Proposed by Jonathan Corwin
Status: Merged
Merged at revision: not available
Proposed branch: lp:~j-corwin/openlp/presentations
Merge into: lp:openlp
Diff against target: 26 lines
1 file modified
openlp/plugins/presentations/lib/__init__.py (+8/-4)
To merge this branch: bzr merge lp:~j-corwin/openlp/presentations
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Jon Tibble (community) Approve
Review via email: mp+12370@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Corwin (j-corwin) wrote :

Not entirely sure about the rules for __init__.py, but these changes get rid of the linux errors.

Revision history for this message
Jon Tibble (meths) wrote :

Looks good.

review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

There should be a blank line between the copyright notice and "import os"

review: Approve
lp:~j-corwin/openlp/presentations updated
569. By Jonathan Corwin

Merge from lp:~j-corwin/openlp/presentations

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/plugins/presentations/lib/__init__.py'
2--- openlp/plugins/presentations/lib/__init__.py 2009-09-23 22:39:37 +0000
3+++ openlp/plugins/presentations/lib/__init__.py 2009-09-24 18:50:45 +0000
4@@ -21,14 +21,18 @@
5 # with this program; if not, write to the Free Software Foundation, Inc., 59 #
6 # Temple Place, Suite 330, Boston, MA 02111-1307 USA #
7 ###############################################################################
8+import os
9
10 from impresscontroller import ImpressController
11-#from powerpointcontroller import PowerpointController
12-from pptviewcontroller import PptviewController
13+if os.name == u'nt':
14+ #from powerpointcontroller import PowerpointController
15+ from pptviewcontroller import PptviewController
16 from messagelistener import MessageListener
17 from mediaitem import PresentationMediaItem
18 from presentationtab import PresentationTab
19
20-
21 __all__ = ['PresentationMediaItem', 'PresentationTab',
22- 'ImpressController', 'ImpressController', 'PowerpointController', 'MessageListener']
23+ 'ImpressController', 'MessageListener']
24+if os.name == u'nt':
25+ __all__.append('PptviewController')
26+ #__all__.append('PowerpointController');