OpenLP

Merge lp:~j-corwin/openlp/present into lp:openlp

  1. present
  2. Merge into trunk
Proposed by Jonathan Corwin
Status: Merged
Merged at revision: 1507
Proposed branch: lp:~j-corwin/openlp/present
Merge into: lp:openlp
Diff against target: 12 lines (+1/-1)
1 file modified
openlp/plugins/presentations/lib/mediaitem.py (+1/-1)
To merge this branch: bzr merge lp:~j-corwin/openlp/present
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Tim Bentley Approve
Review via email: mp+59591@code.launchpad.net

Description of the change

Although preventing users from importing presentations will make supporting it easier, apparently it's not a desirable feature. Remove the "." from the file extension!

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

Well it was better that the original code!

review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/plugins/presentations/lib/mediaitem.py'
2--- openlp/plugins/presentations/lib/mediaitem.py 2011-04-29 22:29:53 +0000
3+++ openlp/plugins/presentations/lib/mediaitem.py 2011-04-30 16:15:49 +0000
4@@ -293,7 +293,7 @@
5 "supports" the extension. If none found, then look for a controller
6 which "also supports" it instead.
7 """
8- filetype = os.path.splitext(filename)[1]
9+ filetype = os.path.splitext(filename)[1][1:]
10 if not filetype:
11 return None
12 for controller in self.controllers: