Code review comment for lp:~j-corwin/openlp/migration

Revision history for this message
Jonathan Corwin (j-corwin) wrote :

On Sun, May 3, 2009 at 12:37 AM, Raoul Snyman <
<email address hidden>> wrote:
y.

>
> I'm a little wary of all these "replace"s - there's probably a better
> way...
>
> replace(replace(replace(replace(replace(replace(replace(replace(
>
> In the original code it was done in the python as lots of individual
replaces. However the python process of selecting 3000 records (in my case)
and updating each one individually took over 5 minutes on my machine.
Doing it in sqlite direct took 5 seconds...

I agree it doesn't look pretty though.

Jonathan.

« Back to merge proposal