Merge lp:~j-corwin/openlp/bug-907792 into lp:openlp
Proposed by
Jonathan Corwin
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 1857 | ||||||||
Proposed branch: | lp:~j-corwin/openlp/bug-907792 | ||||||||
Merge into: | lp:openlp | ||||||||
Diff against target: |
89 lines (+30/-2) 4 files modified
openlp/core/ui/firsttimeform.py (+2/-0) openlp/core/ui/maindisplay.py (+10/-0) openlp/core/ui/screen.py (+15/-0) openlp/core/ui/slidecontroller.py (+3/-2) |
||||||||
To merge this branch: | bzr merge lp:~j-corwin/openlp/bug-907792 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Bentley | Approve | ||
Andreas Preikschat | Pending | ||
Review via email: mp+86839@code.launchpad.net |
This proposal supersedes a proposal from 2011-12-23.
Description of the change
1. If the display window is on the same monitor as the application window, the display window will no longer ever display at program start
2. If the "Display if single monitor" setting is set it will consistently show the output when the user goes live on something. If unset the display will no longer show if the user clicks the hide/show screen buttons.
3. Selecting a different monitor to the default in the First Time Wizard will now open the display window on the selected monitor.
(For after 1.9.8 release.)
To post a comment you must log in.
Only minor things:
- Please fix your docstring in line 51+52.
Return the Screen number that the centre of the passed window is in.
``window``
bla bla
- Please remove line 61.