Merge lp:~ivo-kracht/launchpad/bug-806660 into lp:launchpad

Proposed by Ivo Kracht
Status: Merged
Approved by: Abel Deuring
Approved revision: no longer in the source branch.
Merged at revision: 15500
Proposed branch: lp:~ivo-kracht/launchpad/bug-806660
Merge into: lp:launchpad
Diff against target: 34 lines (+10/-4)
1 file modified
lib/lp/registry/templates/person-editemails.pt (+10/-4)
To merge this branch: bzr merge lp:~ivo-kracht/launchpad/bug-806660
Reviewer Review Type Date Requested Status
Richard Harding (community) Approve
Review via email: mp+112125@code.launchpad.net

Commit message

seperate form for the "Add new address" section

Description of the change

I moved the “Add a new address“ section into a seperate html form. It should now activate the “Add“ button when something is typed into the textbox.

Pre-imp call with adeuring

As far as I (and Abel Deuring) can see there are no tests that check this so I don't list any. I ran all story tests though and there where no errors or failures.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/person-editemails.pt

To post a comment you must log in.
Revision history for this message
Richard Harding (rharding) wrote :

Thanks for the change. Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/registry/templates/person-editemails.pt'
--- lib/lp/registry/templates/person-editemails.pt 2009-09-16 23:54:18 +0000
+++ lib/lp/registry/templates/person-editemails.pt 2012-06-26 14:45:44 +0000
@@ -28,8 +28,7 @@
28 <metal:block use-macro="context/@@launchpad_form/widget_row" />28 <metal:block use-macro="context/@@launchpad_form/widget_row" />
29 </tal:widget>29 </tal:widget>
30 <tr>30 <tr>
31 <td></td>31 <td colspan="2">
32 <td>
33 <input32 <input
34 tal:replace="structure view/action_set_preferred/render" />33 tal:replace="structure view/action_set_preferred/render" />
35 <input tal:replace="structure34 <input tal:replace="structure
@@ -52,11 +51,18 @@
52 </tr>51 </tr>
53 </tal:block>52 </tal:block>
5453
54 </table>
55 </metal:widgets>
56 <metal:widgets fill-slot="buttons" />
57 </div>
58
59 <div metal:use-macro="context/@@launchpad_form/form">
60 <metal:widgets fill-slot="widgets">
61 <table class="form">
55 <tal:widget define="widget nocall:view/widgets/newemail">62 <tal:widget define="widget nocall:view/widgets/newemail">
56 <metal:block use-macro="context/@@launchpad_form/widget_row" />63 <metal:block use-macro="context/@@launchpad_form/widget_row" />
57 <tr>64 <tr>
58 <td></td>65 <td colspan="2">
59 <td>
60 <input tal:replace="structure view/action_add_email/render" />66 <input tal:replace="structure view/action_add_email/render" />
61 </td>67 </td>
62 </tr>68 </tr>