Code review comment for lp:~ivle-dev/ivle/late-submit
Revision history for this message
| Matt Giuca (mgiuca) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Is that 'else:' on line #205 of the diff is to only run that code if no
> exception occurs during submission.
Yes. It's a bit unfortunate, but it has to now go in the 'else' clause because if the project is submitted late, it no longer raises an exception, it continues running the code but doesn't follow the same code path.
> Do we want to highlight late submissions more than just a '*'? Put those lines
> in red perhaps?
It is also italicised. Is that sufficient, or should it be changed to red?