Midori Web Browser

Code review comment for lp:~ivaldi/midori/tabby-about-sessions

  1. tabby-about-sessions
  2. Merge into trunk
Revision history for this message
Cris Dywan (kalikiana) wrote :

Did you consider making contents and mime_type properties rather than functions? That way they could be set and kept around, and used without subclassing.
Will resource-request replace about-content?
Will res:// and stock:// be implemented with resource-request? Then they wouldn't need their own #if for wk2 anymore.

And if I may suggest, this branch looks more like "refactor about: pages with new API" than about:sessions.

review: Needs Information
Reply

« Back to merge proposal