Code review comment for lp:~ivaldi/midori/outsource-webinspector

Revision history for this message
Cris Dywan (kalikiana) wrote :

I dislike saving the hit test result because it is racy and you will eventually encounter a situation where it's not set, this is what happened before with regard to the URI below the mouse pointer and the selected text.

How about taking the hit test result in the context menu event and storing it in the action, in a subclass maybe, which is added to the menu?

review: Needs Fixing

« Back to merge proposal