Merge lp:~ivaldi/midori/history-list into lp:midori

Proposed by André Stösel
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: no longer in the source branch.
Merged at revision: 6176
Proposed branch: lp:~ivaldi/midori/history-list
Merge into: lp:midori
Diff against target: 26 lines (+3/-1)
1 file modified
extensions/history-list.vala (+3/-1)
To merge this branch: bzr merge lp:~ivaldi/midori/history-list
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+165755@code.launchpad.net

Commit message

Fix History List memory leak when closing Midori window.

Description of the change

fix for memory leak when closing midori window

To post a comment you must log in.
lp:~ivaldi/midori/history-list updated
6174. By gue5t <email address hidden>

Compare uri schemes case-insensitively.

6175. By gue5t <email address hidden>

make commandline download-manager handle parameters more consistently, fixing nullable strings

Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve
lp:~ivaldi/midori/history-list updated
6176. By André Stösel

Fix History List memory leak when closing Midori window.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'extensions/history-list.vala'
--- extensions/history-list.vala 2013-05-08 00:50:39 +0000
+++ extensions/history-list.vala 2013-05-25 18:40:32 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 Copyright (C) 2010-2011 André Stösel <andre@stoesel.de>2 Copyright (C) 2010-2013 André Stösel <andre@stoesel.de>
33
4 This library is free software; you can redistribute it and/or4 This library is free software; you can redistribute it and/or
5 modify it under the terms of the GNU Lesser General Public5 modify it under the terms of the GNU Lesser General Public
@@ -578,6 +578,7 @@
578 foreach (var browser in app.get_browsers ())578 foreach (var browser in app.get_browsers ())
579 browser_added (browser);579 browser_added (browser);
580 app.add_browser.connect (browser_added);580 app.add_browser.connect (browser_added);
581 app.remove_browser.connect (browser_removed);
581 }582 }
582583
583 void deactivated () {584 void deactivated () {
@@ -585,6 +586,7 @@
585 foreach (var browser in app.get_browsers ())586 foreach (var browser in app.get_browsers ())
586 browser_removed (browser);587 browser_removed (browser);
587 app.add_browser.disconnect (browser_added);588 app.add_browser.disconnect (browser_added);
589 app.remove_browser.disconnect (browser_removed);
588 }590 }
589591
590 void show_preferences () {592 void show_preferences () {

Subscribers

People subscribed via source and target branches

to all changes: