Code review comment for lp:~ivaldi/midori/devpet-backtrace

Revision history for this message
Cris Dywan (kalikiana) wrote :

To achieve the equivalent of the C code "unowned" is needed - the problem with string[] in your snippet comes from Vala trying to memory-manage a buffer that is already owned by the stack. Also note that the buffer size is one more, same as the C code.

void* buffer[101];
int num = Linux.backtrace (buffer, 100);
unowned string[] symbols = Linux.backtrace_symbols (buffer, num);

If you change it to not use sokoke I'm happy for it to go in.

review: Needs Fixing

« Back to merge proposal