Code review comment for lp:~itohm/nova/lp735974

Hi Jay,

Thanks a lot!
I added 'updated_at' field to the update statement, checked nova-network log and did run_tests.sh. Also rebased to trunk rev 930.
Hope this looks good for people. :)

-Masanori

> Hi!
>
> The synchronize_session parameter is good, thanks!
>
> However, it looks like that update should also be setting the updated_at
> column as well, no?
>
> So, could you add it, like so:
>
> update('instance_id': None,
> 'leased': 0,
> 'updated_at', datetime.datetime.utcnow()}, synchronize_session='fetch')
>
> When running update() form a Query object in SQLalchemy, the normal
> before_update() hooks that would normally set updated_at automatically are not
> fired, which is why I believe the manual setting of updated_at is necessary.
>
> Cheers!
> jay