Code review comment for ~isidroas/ubuntu/+source/command-not-found:black_formatter

Revision history for this message
Julian Andres Klode (juliank) wrote :

While I appreciate format cleanups I'm not sure this is the best venue for this type of change, because I'd have to run black locally myself, and then compare the outcomes anyway, and there's no work to make sure future uploads are correctly formatted.

Ultimately it would be nice to setup the launchpad CI thingy and https://pre-commit.com/ that runs ruff to format the code and do linting of it (or alternatively the individual tools, but it seems the community is gravitating towards ruff these days) and fail if linting fails or ruff fails.

Not sure if now is the right time for this, I believe that ultimately this would improve quality for 24.04, and it's not a feature, so it should not be affected by feature freeze.

What do you think?

« Back to merge proposal