Merge lp:~invitu/openobject-addons/7.0-fix-1179307-1179305 into lp:openobject-addons/7.0

Proposed by invitu
Status: Needs review
Proposed branch: lp:~invitu/openobject-addons/7.0-fix-1179307-1179305
Merge into: lp:openobject-addons/7.0
Diff against target: 222 lines (+44/-22)
12 files modified
account/account.py (+8/-2)
account/account_invoice.py (+5/-3)
crm/crm_lead_view.xml (+4/-0)
crm/report/crm_phonecall_report.py (+2/-0)
crm/report/crm_phonecall_report_view.xml (+2/-0)
email_template/res_partner.py (+1/-1)
hr_payroll/hr_payroll.py (+1/-1)
mail/res_partner.py (+1/-1)
mrp/mrp_view.xml (+0/-1)
project_timesheet/project_timesheet.py (+3/-1)
report_webkit/__openerp__.py (+3/-2)
stock/stock_view.xml (+14/-10)
To merge this branch: bzr merge lp:~invitu/openobject-addons/7.0-fix-1179307-1179305
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) (community) Needs Resubmitting
OpenERP Core Team Pending
Review via email: mp+165790@code.launchpad.net

Description of the change

[IMP] lp:1179307-[7.0:addons/crm] add lead group in phonecall reporting
[FIX] lp:1179305-[7.0:addons/crm] Fix direct link to phonecalls and meetings in lead view

To post a comment you must log in.
Revision history for this message
invitu (invitu) wrote :

merge proposal comes from ocb-addons branch

9178. By invitu

[IMP] lp:1179307-[7.0:addons/crm] add lead group in phonecall reporting
[FIX] lp:1179305-[7.0:addons/crm] Fix direct link to phonecalls and meetings in lead view

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Invitu,

your branch includes other fixes from ocb. Please try again, for instance in the following way by cherrypicking the relevant revision:

bzr branch lp:openobject-addons/7.0
cd 7.0
bzr merge lp:~invitu/ocb-addons/7.0-fix-1179307-1179305 -r 9177..9178

Then push and propose to openobject-addons.

review: Needs Resubmitting

Unmerged revisions

9178. By invitu

[IMP] lp:1179307-[7.0:addons/crm] add lead group in phonecall reporting
[FIX] lp:1179305-[7.0:addons/crm] Fix direct link to phonecalls and meetings in lead view

9177. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

9176. By Thibault Delavallée (OpenERP)

[FIX] Chatter: fixed suggested recipients, when having no email, unchecking the box was not taken into account.

9175. By Thibault Delavallée (OpenERP)

[FIX] project_issue: fixed access rights issues when truing to find suggested partners.

9174. By Martin Trigaux (OpenERP)

[IMP] hr_timesheet_sheet: dispay timesheets as time_float instead of float

9173. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

9172. By Martin Trigaux (OpenERP)

[MERGE] [FIX] account_followup: remove create button in report

9171. By Martin Trigaux (OpenERP)

[MERGE] [FIX] res partner copy method returns None

9170. By Quentin (OpenERP) <email address hidden>

[FIX] account: divide the residual amount of invoices proportionally to the number of invoices partially reconciled together if needed + if necessary, do a conversion at the right currency rate

9169. By Quentin (OpenERP) <email address hidden>

[FIX] account: exclude company_id from build_ctx_periods()'s criteria to allow printing consolidated reports

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account/account.py'
--- account/account.py 2013-05-23 12:27:56 +0000
+++ account/account.py 2013-05-27 04:26:42 +0000
@@ -1040,9 +1040,15 @@
1040 context = {}1040 context = {}
1041 ids = []1041 ids = []
1042 if name:1042 if name:
1043 ids = self.search(cr, user, [('code','ilike',name)]+ args, limit=limit)1043 ids = self.search(cr, user,
1044 [('code', 'ilike', name)] + args,
1045 limit=limit,
1046 context=context)
1044 if not ids:1047 if not ids:
1045 ids = self.search(cr, user, [('name',operator,name)]+ args, limit=limit)1048 ids = self.search(cr, user,
1049 [('name', operator, name)] + args,
1050 limit=limit,
1051 context=context)
1046 return self.name_get(cr, user, ids, context=context)1052 return self.name_get(cr, user, ids, context=context)
10471053
1048 def write(self, cr, uid, ids, vals, context=None):1054 def write(self, cr, uid, ids, vals, context=None):
10491055
=== modified file 'account/account_invoice.py'
--- account/account_invoice.py 2013-05-23 12:28:55 +0000
+++ account/account_invoice.py 2013-05-27 04:26:42 +0000
@@ -778,9 +778,11 @@
778778
779 def action_date_assign(self, cr, uid, ids, *args):779 def action_date_assign(self, cr, uid, ids, *args):
780 for inv in self.browse(cr, uid, ids):780 for inv in self.browse(cr, uid, ids):
781 res = self.onchange_payment_term_date_invoice(cr, uid, inv.id, inv.payment_term.id, inv.date_invoice)781 if not inv.date_due:
782 if res and res['value']:782 res = self.onchange_payment_term_date_invoice(cr, uid, inv.id,
783 self.write(cr, uid, [inv.id], res['value'])783 inv.payment_term.id, inv.date_invoice)
784 if res and res['value']:
785 self.write(cr, uid, [inv.id], res['value'])
784 return True786 return True
785787
786 def finalize_invoice_move_lines(self, cr, uid, invoice_browse, move_lines):788 def finalize_invoice_move_lines(self, cr, uid, invoice_browse, move_lines):
787789
=== modified file 'crm/crm_lead_view.xml'
--- crm/crm_lead_view.xml 2013-04-20 02:26:42 +0000
+++ crm/crm_lead_view.xml 2013-05-27 04:26:42 +0000
@@ -73,16 +73,20 @@
73 name="Phone calls"73 name="Phone calls"
74 groups="base.group_sale_salesman"74 groups="base.group_sale_salesman"
75 res_model="crm.phonecall"75 res_model="crm.phonecall"
76 src_model="crm.lead"
76 view_mode="tree,calendar,form"77 view_mode="tree,calendar,form"
77 context="{'default_duration': 1.0 ,'default_opportunity_id': active_id}"78 context="{'default_duration': 1.0 ,'default_opportunity_id': active_id}"
79 domain="[('opportunity_id', '=', active_id)]"
78 view_type="form"/>80 view_type="form"/>
7981
80 <act_window82 <act_window
81 id="act_crm_opportunity_crm_meeting_new"83 id="act_crm_opportunity_crm_meeting_new"
82 name="Meetings"84 name="Meetings"
83 res_model="crm.meeting"85 res_model="crm.meeting"
86 src_model="crm.lead"
84 view_mode="tree,form,calendar"87 view_mode="tree,form,calendar"
85 context="{'default_duration': 4.0, 'default_opportunity_id': active_id}"88 context="{'default_duration': 4.0, 'default_opportunity_id': active_id}"
89 domain="[('opportunity_id', '=', active_id)]"
86 view_type="form"/>90 view_type="form"/>
8791
8892
8993
=== modified file 'crm/report/crm_phonecall_report.py'
--- crm/report/crm_phonecall_report.py 2012-12-06 14:56:32 +0000
+++ crm/report/crm_phonecall_report.py 2013-05-27 04:26:42 +0000
@@ -61,6 +61,7 @@
61 domain="[('section_id','=',section_id),\61 domain="[('section_id','=',section_id),\
62 ('object_id.model', '=', 'crm.phonecall')]"),62 ('object_id.model', '=', 'crm.phonecall')]"),
63 'partner_id': fields.many2one('res.partner', 'Partner' , readonly=True),63 'partner_id': fields.many2one('res.partner', 'Partner' , readonly=True),
64 'opportunity_id': fields.many2one('crm.lead', 'Lead/Opportunity' , readonly=True),
64 'company_id': fields.many2one('res.company', 'Company', readonly=True),65 'company_id': fields.many2one('res.company', 'Company', readonly=True),
65 'opening_date': fields.date('Opening Date', readonly=True, select=True),66 'opening_date': fields.date('Opening Date', readonly=True, select=True),
66 'creation_date': fields.date('Creation Date', readonly=True, select=True),67 'creation_date': fields.date('Creation Date', readonly=True, select=True),
@@ -88,6 +89,7 @@
88 c.section_id,89 c.section_id,
89 c.categ_id,90 c.categ_id,
90 c.partner_id,91 c.partner_id,
92 c.opportunity_id,
91 c.duration,93 c.duration,
92 c.company_id,94 c.company_id,
93 c.priority,95 c.priority,
9496
=== modified file 'crm/report/crm_phonecall_report_view.xml'
--- crm/report/crm_phonecall_report_view.xml 2013-04-20 02:26:42 +0000
+++ crm/report/crm_phonecall_report_view.xml 2013-05-27 04:26:42 +0000
@@ -16,6 +16,7 @@
16 <field name="user_id" invisible="1"/>16 <field name="user_id" invisible="1"/>
17 <field name="company_id" invisible="1"/>17 <field name="company_id" invisible="1"/>
18 <field name="partner_id" invisible="1"/>18 <field name="partner_id" invisible="1"/>
19 <field name="opportunity_id" invisible="1"/>
19 <field name="state" invisible="1"/>20 <field name="state" invisible="1"/>
20 <field name="categ_id" invisible="1"/>21 <field name="categ_id" invisible="1"/>
21 <field name="day" invisible="1"/>22 <field name="day" invisible="1"/>
@@ -72,6 +73,7 @@
72 <filter string="Salesperson" name="Salesperson" icon="terp-personal" domain="[]" context="{'group_by':'user_id'}" />73 <filter string="Salesperson" name="Salesperson" icon="terp-personal" domain="[]" context="{'group_by':'user_id'}" />
73 <filter string="Sales Team" icon="terp-personal+" domain="[]" context="{'group_by':'section_id'}" />74 <filter string="Sales Team" icon="terp-personal+" domain="[]" context="{'group_by':'section_id'}" />
74 <filter string="Partner" icon="terp-partner" context="{'group_by':'partner_id'}" />75 <filter string="Partner" icon="terp-partner" context="{'group_by':'partner_id'}" />
76 <filter string="Lead/Opportunity" icon="terp-personal+" context="{'group_by':'opportunity_id'}" />
75 <filter string="Priority" icon="terp-rating-rated" domain="[]" context="{'group_by':'priority'}" />77 <filter string="Priority" icon="terp-rating-rated" domain="[]" context="{'group_by':'priority'}" />
76 <filter string="Category" icon="terp-stock_symbol-selection" domain="[]" context="{'group_by':'categ_id'}" />78 <filter string="Category" icon="terp-stock_symbol-selection" domain="[]" context="{'group_by':'categ_id'}" />
77 <filter string="Status" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}" />79 <filter string="Status" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}" />
7880
=== modified file 'email_template/res_partner.py'
--- email_template/res_partner.py 2013-03-13 11:20:13 +0000
+++ email_template/res_partner.py 2013-05-27 04:26:42 +0000
@@ -34,7 +34,7 @@
34 }34 }
3535
36 _defaults = {36 _defaults = {
37 'opt_out': False,37 'opt_out': True,
38 }38 }
3939
40# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:40# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
4141
=== modified file 'hr_payroll/hr_payroll.py'
--- hr_payroll/hr_payroll.py 2013-04-23 09:16:26 +0000
+++ hr_payroll/hr_payroll.py 2013-05-27 04:26:42 +0000
@@ -385,7 +385,7 @@
385 #OR if it starts between the given dates385 #OR if it starts between the given dates
386 clause_2 = ['&',('date_start', '<=', date_to),('date_start','>=', date_from)]386 clause_2 = ['&',('date_start', '<=', date_to),('date_start','>=', date_from)]
387 #OR if it starts before the date_from and finish after the date_end (or never finish)387 #OR if it starts before the date_from and finish after the date_end (or never finish)
388 clause_3 = [('date_start','<=', date_from),'|',('date_end', '=', False),('date_end','>=', date_to)]388 clause_3 = ['&',('date_start','<=', date_from),'|',('date_end', '=', False),('date_end','>=', date_to)]
389 clause_final = [('employee_id', '=', employee.id),'|','|'] + clause_1 + clause_2 + clause_3389 clause_final = [('employee_id', '=', employee.id),'|','|'] + clause_1 + clause_2 + clause_3
390 contract_ids = contract_obj.search(cr, uid, clause_final, context=context)390 contract_ids = contract_obj.search(cr, uid, clause_final, context=context)
391 return contract_ids391 return contract_ids
392392
=== modified file 'mail/res_partner.py'
--- mail/res_partner.py 2013-03-13 12:51:24 +0000
+++ mail/res_partner.py 2013-05-27 04:26:42 +0000
@@ -43,7 +43,7 @@
43 }43 }
4444
45 _defaults = {45 _defaults = {
46 'notification_email_send': lambda *args: 'comment'46 'notification_email_send': lambda *args: 'none'
47 }47 }
4848
49 def message_get_suggested_recipients(self, cr, uid, ids, context=None):49 def message_get_suggested_recipients(self, cr, uid, ids, context=None):
5050
=== modified file 'mrp/mrp_view.xml'
--- mrp/mrp_view.xml 2013-03-19 12:52:16 +0000
+++ mrp/mrp_view.xml 2013-05-27 04:26:42 +0000
@@ -461,7 +461,6 @@
461 <field name="field_parent">child_complete_ids</field>461 <field name="field_parent">child_complete_ids</field>
462 <field name="arch" type="xml">462 <field name="arch" type="xml">
463 <tree string="BoM Structure" colors="blue:method">463 <tree string="BoM Structure" colors="blue:method">
464 <field name="sequence" invisible="1"/>
465 <field name="name" groups="base.group_no_one"/>464 <field name="name" groups="base.group_no_one"/>
466 <field name="code"/>465 <field name="code"/>
467 <field name="product_id"/>466 <field name="product_id"/>
468467
=== modified file 'project_timesheet/project_timesheet.py'
--- project_timesheet/project_timesheet.py 2012-12-18 22:50:15 +0000
+++ project_timesheet/project_timesheet.py 2013-05-27 04:26:42 +0000
@@ -200,7 +200,9 @@
200 if amount_unit and 'amount' in amount_unit.get('value',{}):200 if amount_unit and 'amount' in amount_unit.get('value',{}):
201 vals_line['amount'] = amount_unit['value']['amount']201 vals_line['amount'] = amount_unit['value']['amount']
202202
203 self.pool.get('hr.analytic.timesheet').write(cr, uid, [line_id.id], vals_line, context=context)203 if vals_line:
204 self.pool.get('hr.analytic.timesheet').write(cr, uid,
205 [line_id.id], vals_line, context=context)
204206
205 return super(project_work,self).write(cr, uid, ids, vals, context)207 return super(project_work,self).write(cr, uid, ids, vals, context)
206208
207209
=== modified file 'report_webkit/__openerp__.py'
--- report_webkit/__openerp__.py 2013-05-14 14:28:37 +0000
+++ report_webkit/__openerp__.py 2013-05-27 04:26:42 +0000
@@ -62,8 +62,9 @@
62PDF. Version 0.9.9 or later is necessary, and can be found at62PDF. Version 0.9.9 or later is necessary, and can be found at
63http://code.google.com/p/wkhtmltopdf/ for Linux, Mac OS X (i386) and Windows (32bits).63http://code.google.com/p/wkhtmltopdf/ for Linux, Mac OS X (i386) and Windows (32bits).
6464
65After installing the library on the OpenERP Server machine, you need to set the65After installing the library on the OpenERP Server machine, you need to set
66path to the ``wkthtmltopdf`` executable file on each Company.66the path to the ``wkthtmltopdf`` executable file in a system parameter named ``webkit_path``
67in Settings -> Customization -> Low Level Object -> System Parameters
6768
68If you are experiencing missing header/footer problems on Linux, be sure to69If you are experiencing missing header/footer problems on Linux, be sure to
69install a 'static' version of the library. The default ``wkhtmltopdf`` on70install a 'static' version of the library. The default ``wkhtmltopdf`` on
7071
=== modified file 'stock/stock_view.xml'
--- stock/stock_view.xml 2013-05-14 09:19:14 +0000
+++ stock/stock_view.xml 2013-05-27 04:26:42 +0000
@@ -337,16 +337,20 @@
337 <field name="model">stock.production.lot</field>337 <field name="model">stock.production.lot</field>
338 <field name="arch" type="xml">338 <field name="arch" type="xml">
339 <form string="Serial Number" version="7.0">339 <form string="Serial Number" version="7.0">
340 <div class="oe_button_box oe_right">340 <group>
341 <button name="action_traceability" string="Upstream Traceability" type="object" context="{'type': 'move_history_ids2', 'field': 'prodlot_id'}"/>341 <div>
342 <button name="action_traceability" string="Downstream Traceability" type="object" context="{'type': 'move_history_ids', 'field': 'prodlot_id'}"/>342 <div class="oe_button_box oe_right">
343 </div>343 <button name="action_traceability" string="Upstream Traceability" type="object" context="{'type': 'move_history_ids2', 'field': 'prodlot_id'}"/>
344 <div class="oe_title">344 <button name="action_traceability" string="Downstream Traceability" type="object" context="{'type': 'move_history_ids', 'field': 'prodlot_id'}"/>
345 <label for="name" class="oe_edit_only"/>345 </div>
346 <h1>346 <div class="oe_title">
347 <field name="name"/>347 <label for="name" class="oe_edit_only"/>
348 </h1>348 <h1>
349 </div>349 <field name="name"/>
350 </h1>
351 </div>
352 </div>
353 </group>
350 <group>354 <group>
351 <group>355 <group>
352 <field name="product_id"/>356 <field name="product_id"/>